Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to accommodate Splash events in ECAL DQM [CMSSW_12_0_X] #35747

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

abhih1
Copy link
Contributor

@abhih1 abhih1 commented Oct 20, 2021

PR description:

During splash events, we often have very poor signal shapes. In addition, it is useful to view these events in a wider time window than the default configuration. This PR changes the timing windows and removes a chi-square constraint to make DQM more useful during splash events. This also adds an option options.BeamSplashRun to the ecal dqm client config to activate splash run mode in DQM, following the comment #35734 (comment)

PR validation:

Validated by the standard Ecal DQM configuration by manually setting options.BeamSplashRun to True and False and comparing the output plots. Results look as expected.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 20, 2021

A new Pull Request was created by @abhih1 (Abhirami Harilal) for CMSSW_12_0_X.

It involves the following packages:

  • DQM/EcalMonitorTasks (dqm)
  • DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@batinkov, @battibass, @rchatter, @argiro, @thomreis, @simonepigazzini, @threus, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

test parameters:

  • addpkg = DQM/Integration

@jfernan2
Copy link
Contributor

please test

@jfernan2
Copy link
Contributor

@abhih1 since this PR is to stay given that the switch to Splashes will drive the data, we (actually) need a forwardport to Master.
Sorry for the dizziness
Thank you!

@abhih1 abhih1 changed the title Changes to accommodate Splash events in ECAL DQM Changes to accommodate Splash events in ECAL DQM [CMSSW_12_0_X] Oct 20, 2021
@abhih1
Copy link
Contributor Author

abhih1 commented Oct 20, 2021

@jfernan2 Thanks. :) Here's the PR to the master #35755

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b88b12/19776/summary.html
COMMIT: db6808a
CMSSW: CMSSW_12_0_X_2021-10-19-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35747/19776/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998542
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@qliphy
Copy link
Contributor

qliphy commented Oct 21, 2021

backport of #35755

@jfernan2
Copy link
Contributor

+1
Tested in Online DQM at P5

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@abhih1
Copy link
Contributor Author

abhih1 commented Oct 21, 2021

Hello, can this be included in time for the next Splashes tomorrow?
Thanks.

@perrotta
Copy link
Contributor

+1

  • Already merged in the master PR, and succesfully tested in CMSSW_12_1_X_2021-10-21-2300

@cmsbuild cmsbuild merged commit 921c69c into cms-sw:CMSSW_12_0_X Oct 22, 2021
@abhih1 abhih1 deleted the SplashEventsNew1202patch2 branch July 6, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants