-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to accommodate Splash events in ECAL DQM [CMSSW_12_0_X] #35747
Changes to accommodate Splash events in ECAL DQM [CMSSW_12_0_X] #35747
Conversation
A new Pull Request was created by @abhih1 (Abhirami Harilal) for CMSSW_12_0_X. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
test parameters:
|
please test |
@abhih1 since this PR is to stay given that the switch to Splashes will drive the data, we (actually) need a forwardport to Master. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b88b12/19776/summary.html Comparison SummarySummary:
|
backport of #35755 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
Hello, can this be included in time for the next Splashes tomorrow? |
+1
|
PR description:
During splash events, we often have very poor signal shapes. In addition, it is useful to view these events in a wider time window than the default configuration. This PR changes the timing windows and removes a chi-square constraint to make DQM more useful during splash events. This also adds an option
options.BeamSplashRun
to the ecal dqm client config to activate splash run mode in DQM, following the comment #35734 (comment)PR validation:
Validated by the standard Ecal DQM configuration by manually setting
options.BeamSplashRun
to True and False and comparing the output plots. Results look as expected.