+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35722/26047

• This PR adds an extra 16KB to repository

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

• HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

test parameters:

• workflows_gpu = 11634.502,11634.506,11634.512,11634.522,11634.592,11634.596,11650.502,11650.506
• enable_tests = gpu

@cmsbuild, please test

Tests are stuck?

@cmsbuild, please abort

@cmsbuild, please test

@smuzaffar Any idea why the tests are stuck in "Waiting for tests to start"?

@cmsbuild ping

@cmsbuild ping

The Jenkins build seems to be sussecfully ran
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/19734/console

the gpu relval comparison job failed as the baseline failed to run any of the gpus relval ( https://cmssdt.cern.ch/SDT/jenkins-artifacts/ib-baseline-tests/CMSSW_12_1_X_2021-10-19-1100/slc7_amd64_gcc900/-GenuineIntel/matrixgpu-results/runall-report-step123-.log ). I will fix the bot to not just fail but to report back that it is not able to run gpu comparison

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4f0f34/19734/summary.html
COMMIT: de0fd9a
CMSSW: CMSSW_12_1_X_2021-10-19-1100/slc7_amd64_gcc900
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35722/19734/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 2751113
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2751084
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 39 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 170 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

Just to clarify (to myself) that with this PR all the tested GPU workflows succeeded

11634.502_TTbar_14TeV+2021_Patatrack_PixelOnlyGPU+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Tue Oct 19 14:42:49 2021-date Tue Oct 19 14:33:30 2021; exit: 0 0 0 0
11634.506_TTbar_14TeV+2021_Patatrack_PixelOnlyTripletsGPU+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Tue Oct 19 14:42:50 2021-date Tue Oct 19 14:33:31 2021; exit: 0 0 0 0
11634.512_TTbar_14TeV+2021_Patatrack_ECALOnlyGPU+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Tue Oct 19 14:42:35 2021-date Tue Oct 19 14:33:31 2021; exit: 0 0 0 0
11634.522_TTbar_14TeV+2021_Patatrack_HCALOnlyGPU+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Tue Oct 19 14:42:35 2021-date Tue Oct 19 14:33:32 2021; exit: 0 0 0 0
11634.592_TTbar_14TeV+2021_Patatrack_GPU+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Tue Oct 19 14:54:40 2021-date Tue Oct 19 14:42:36 2021; exit: 0 0 0 0
11634.596_TTbar_14TeV+2021_Patatrack_TripletsGPU+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Tue Oct 19 14:54:40 2021-date Tue Oct 19 14:42:36 2021; exit: 0 0 0 0
11650.502_ZMM_14+2021_Patatrack_PixelOnlyGPU+ZMM_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Tue Oct 19 14:50:24 2021-date Tue Oct 19 14:42:50 2021; exit: 0 0 0 0
11650.506_ZMM_14+2021_Patatrack_PixelOnlyTripletsGPU+ZMM_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Tue Oct 19 14:50:24 2021-date Tue Oct 19 14:42:50 2021; exit: 0 0 0 0
8 8 8 8 tests passed, 0 0 0 0 failed

correct @makortel
I would suggest that if there are no other issues with PR then merge it so that GPU IBs get these workflows running

+hlt

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

+1

merge