Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Online DQM] re-introduce unit tests for visualization: 12.0.X #35689

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 15, 2021

backport of #35642

PR description:

Apparently #35561 has fixed a long-standing issue, leading to not being able to run the visualization unit tests.

PR validation:

Run cmsRun DQM/Integration/python/clients/visualization-live_cfg.py unitTest=True in a recent IB adding commits of PR #35653 and it run successfully.

if this PR is a backport please specify the original PR and why you need to backport that PR:

backport of PR #35642

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 15, 2021

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_0_X.

It involves the following packages:

  • DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@battibass, @threus, @batinkov, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

backport of #35642

@mmusich mmusich changed the title [Online DQM] re-inroduce unit tests for visualization: 12.0.X [Online DQM] re-introduce unit tests for visualization: 12.0.X Oct 15, 2021
@mmusich
Copy link
Contributor Author

mmusich commented Oct 16, 2021

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8974b1/19688/summary.html
COMMIT: 1e00267
CMSSW: CMSSW_12_0_X_2021-10-16-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35689/19688/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998542
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Oct 18, 2021

+1

@cmsbuild cmsbuild merged commit 18da2ab into cms-sw:CMSSW_12_0_X Oct 18, 2021
@mmusich mmusich deleted the updateDQMIntegrationUnitTests_12_0_X branch October 18, 2021 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants