-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve various Patatrack Kernels #35598
Closed
+22,724
−8,289
Closed
Changes from 12 commits
Commits
Show all changes
527 commits
Select commit
Hold shift + click to select a range
c43922e
edm::FileInPath for model and scalers files
valsdav 493fe63
Disable PFiso computation if the DNN is disabled
valsdav fdf6fa3
Added new DNN info in the PFCandidate dataformat
valsdav 0eece82
Improvements for TF sessions and fixes
valsdav fd49b69
Code improvements
valsdav 920a5cc
Improved code for DNN estimator
valsdav 7e35ef8
Removed logLevel from EgammaDNNHelper
valsdav 105e752
Fixed bug in storing of DNN outputs in GsfElectronProducer
valsdav 585ff66
Added getters in PFCandidate, fixed missing scaling mode in EgammaDNN…
valsdav 0904547
Disabled by default DNN Egamma PFID for pre4
valsdav 0f05158
Enabled back Egm PFid by default; endRun -> endStream for sessions cl…
valsdav 80281d2
Fixed code-checks, added const to PFCandidate getters
valsdav f45b48a
From atomic to unique_ptr for Tensorflow GraphDef
valsdav 4ef649b
code quality changes
mundim aba80dc
Intro unit test for PPSAssociationCuts
tvami e0e66ae
Made LeptonVertexSignificance independent of Event and EventSetup
Dr15Jones f611518
Add esConsumes calls to modules in PhysicsTools/PatUtils
Dr15Jones 446b461
Merge pull request #35671 from fabferro/patch-1
cmsbuild 9e1f6a5
Merge pull request #35669 from tvami/FixPPSAssociationCuts
cmsbuild a8ce9fc
Merge pull request #35673 from Dr15Jones/deprecatedDDCMS
cmsbuild 7d0e4f1
Merge pull request #35675 from mmusich/possible_fix_for_BSReadUnitTest
cmsbuild 737fca2
Use edm::ESGetToken when getting JME::JetResolution*
Dr15Jones 2c2b1fa
Fix CMS deprecation warnings in JetMETCorrections/Modules
Dr15Jones 8fe4166
Fix a crash caused by the missing luminosityBlockAuxiliary.
smorovic 18da2f8
Use correct record
Dr15Jones 80c3717
Merge pull request #35676 from Dr15Jones/deprecatedSimG4CoreDD4hepGeo…
cmsbuild f5b4310
Merge pull request #35617 from lwang046/HcalDQM-UpdateFEDlist
cmsbuild fe01eae
Merge pull request #35454 from ChrisMisan/diamondDQM
cmsbuild d6091aa
load the onlineBeamSpotESProducer only if the modifier is called
mmusich ea55c81
Update RecoLocalTracker/SiPixelClusterizer/plugins/gpuClusterChargeCut.h
VinInn c835c7e
Added new parameters from PPSAlignmentConfiguration to README.
MatiXOfficial e95e45a
Updated the worker and the harvester.
MatiXOfficial e8034f0
code-format
MatiXOfficial de0e90b
Updated the test folder.
MatiXOfficial 7d0adcb
Deleted unused cfi files.
MatiXOfficial 3392c4d
Added RetrieveCTPPSRPAlignmentCorrectionsData.
MatiXOfficial 96265b8
p_x_diffFN_vs_x_N is now rebooked in the harvester.
MatiXOfficial 5ac57ed
Mode graph is now a TH1D.
MatiXOfficial 2fdc167
Updated the AlignmentGlobal test (README and run_distributions_cfg.py).
MatiXOfficial 3f7638b
Included PPS alignment in the PCL and added new matrix test.
MatiXOfficial 1673da0
Replaced writeOne with writeOneIOV in PPSAlignmentHarvester.
MatiXOfficial a15127c
Clean up and avoid possible misuse of the numOfBins variable
perrotta 75a3e21
Merge pull request #35638 from fwyzard/Add_fishbone_protection_121x
cmsbuild 00ec75b
Take Andrea's comments
66f3654
Code format
8b40f21
Fixed typos
quark2 2d25d78
provide a reconstruction scenario for the commissioning_run type intr…
mmusich 11e4f0f
Merge pull request #35677 from mmusich/CondTools_SiPhase2TrackerUnitT…
cmsbuild 88a57b6
Improvements to LeptonVertexSignificance
Dr15Jones 203a22f
Rearrange the code to enable future implementation of SimProducer class
0607f7a
adding ALCARECOTkAlCosmicsCosmicTF0T track collection in Millepede code
5b230af
Merge pull request #35639 from mmusich/fixBSswap_forDQMVis
cmsbuild 4820d23
Removing uneeded comma in config files and adding a missing call to c…
mundim be1a27e
code-format modification
mundim 4b527f4
fix typo in _loadOnlineBeamSpotESProducer
mmusich a17ac4a
Merge pull request #35642 from mmusich/updateDQMIntegrationUnitTests
cmsbuild 7e11783
removed unnecessary includes
Dr15Jones 4e51b62
Added esConsumes calls to Muon related code
Dr15Jones aefd5fd
Merge pull request #35682 from smorovic/121X-fix-ls-assert
cmsbuild 3152213
Add ONNX and batch eval in BaseMVAValueMapProducer
hqucms 5453ecc
Use ONNX for b/c-jet regression in NanoAOD.
hqucms 764854b
switched to using std::unique_ptr for memory management
Dr15Jones 275e077
Small tweak.
hqucms 17e5ac9
Merge pull request #35696 from mmusich/fixBSswap_forDQMVis
cmsbuild 1603475
Merge pull request #35672 from Dr15Jones/deprecatedMagneticFieldEngine
cmsbuild eec2351
Merge pull request #35687 from perrotta/cleanUpDiamondSampicDqmSource
cmsbuild ef94ed3
Avoid use of uninitalized values in GBRForestTools
Dr15Jones b287a26
Fix batch eval when the collection is empty.
hqucms 4b3df9f
Flip the byte order
f4b31e4
Apply code-format
99de356
Merge pull request #35702 from guitargeek/trackselectionRefitting_1
cmsbuild ff55d32
Merge pull request #35680 from Dr15Jones/deprecatedPhysicsToolsPatUtils
cmsbuild 8c67a1f
Merge pull request #35694 from antoniovagnerini/from-CMSSW_12_1_0_pre4
cmsbuild fcdf7ae
updating hltDumpStream to work in python3
Sam-Harper 0d92bbb
Merge pull request #35709 from Sam-Harper/hltDumpPatch_1210pre3
cmsbuild c2acb4a
Merge pull request #35690 from quark2/GEM-onlineDQMForFixingTypo-12_1_X
cmsbuild bd7feec
Merge pull request #35620 from CMSTrackingPOG/muontrackrefit
cmsbuild ecb8424
Merge pull request #35665 from Dr15Jones/deprecatedGeneratorInterface
cmsbuild 33356e6
Merge pull request #35658 from jfernan2/patch-12
cmsbuild 42c9ea8
Merge pull request #35661 from alejands/bxFirstLastLabels_121X
cmsbuild b13a1b3
Remove unnecessary type specifiers and clean
mbluj c2c990b
squashing
swagata87 a5ac225
Updated run3 hlt, express and prompt GTs in autoCond.py.
MatiXOfficial ba35d53
Merge pull request #35692 from bsunanda/Run3-hcx324
cmsbuild 2b93301
Merge pull request #35664 from bsunanda/Run3-hcx323
cmsbuild 5c87671
Merge pull request #35403 from valsdav/egamma_tensorflow_pfid
cmsbuild bd6896f
Merge pull request #35695 from swagata87/DTcalib_On_pre4
cmsbuild 0275250
Merge pull request #35691 from mmusich/provide_reconstruction_scenari…
cmsbuild f64be03
add printounts to beam clients + set ED clients default splash settings
pmandrik 1496ed8
Made DQMHelper consistent with DQMEDAnalyzer
Dr15Jones e850268
Use esConsumes for modules in Validation/EventGenerator
Dr15Jones 8c35d62
Use ESGetToken in getting objects from EventSetup
56bde9a
Pass InputType to StatisticsSenderService
Dr15Jones 467ce1e
Code format
4f8c915
create trackingNoLoopers modifier and use it
mmusich f4af6b3
Take Amtti's suggestions
d9e7806
Merge pull request #35681 from Dr15Jones/deprecatedJetMETCorrectionsM…
cmsbuild 59b5b6e
Merge pull request #35619 from cms-tau-pog/CMSSW_12_0_X_tau-pog_DeepT…
cmsbuild 87c2099
Adding SiPixelLorentzAngleRcd PCL tags
tvami d3f069b
Adding CTPPS PCL tags
tvami 6333f73
Code format
733a801
Converted the raw pointers that required delete to smart pointers.
MatiXOfficial de0fd9a
Explicitly remove and insert AlCa_LumiPixelsCounts_{Random,ZeroBias}_…
makortel 87a4087
Merge pull request #35697 from Dr15Jones/esConsumesMuonLeftovers
cmsbuild d401592
Merge pull request #35654 from ChrisMisan/EventFilterFix
cmsbuild 3c60d77
Merge pull request #35705 from Dr15Jones/fixUninitGBRForestTools
cmsbuild 5e69593
Change config file to create a tag incl SiPixelLA and CTPPS
tvami 99a1dc4
change bx constant to centrally defined value defined in DataFormats/…
perrotta 2dfe916
Bug Fix for CLUE in BH section of HGCAL
rovere fb52070
Add multiprocess support into compareHistograms
rovere 596662e
Merge pull request #35720 from tvami/NewMetaDataWfs
cmsbuild 6254eee
Transition from watcher to producer for HcalTestAnalysis
d952116
Code check
d68381f
avoid double deletion of smart pointers leading to random unit test c…
mmusich 6861d57
Using predefined PPSUnitConvertion.h instead of hardcoded constant fo…
mundim 70b6da8
Merge pull request #35716 from Dr15Jones/esConsumesValidationEventGen…
cmsbuild 3f31845
Merge pull request #35725 from perrotta/updateRawDataTask
cmsbuild ee09541
Fixed a wrong binning
quark2 21ae653
Merge pull request #35718 from bsunanda/Run3-sim93
cmsbuild 419cab1
add SiPhase2OuterTrackerLorentzAngleReader and use it in unit tests
mmusich fd8dd86
Merge pull request #35652 from trackreco/updateMkFit_12_1_0_pre5
cmsbuild 3bf0da7
Merge pull request #35703 from guitargeek/GsfTools_1
cmsbuild 97af9c9
apply the noLoopers processModifier to Run2 2016 era and exclude it f…
mmusich a6c89bd
L2 tau identification with a CNN
valeriadamante 05a4e22
Implementing changes from PR review
azotz de2f6c6
Fix path to get normalisatin json file
mbluj f5c2d8a
Remove type specifications from customisation; Use HLT_GRun_cff from …
mbluj 3b10c57
Add the L2CNN to unit tests
mbluj c6238a5
implement many comments from PR review
azotz aa12144
make trimmed pixel vertex related variables configurable
azotz 8ce60cc
replacing EventSetup with esConsumes
azotz c41e862
Merge pull request #35660 from trackreco/extendMkFitProdModifier_12_1…
cmsbuild 2e838c0
Merge pull request #35563 from bsunanda/Phase2-hgx291
cmsbuild 0c9e1ed
Use SimProducer for TB material budget studies
4d7de70
Code check
abd776a
Change trapezoid precision to 8
cvuosalo 37fece7
Merge pull request #35728 from rovere/CompareHistoMP
cmsbuild 2816b39
Merge pull request #35631 from CTPPS/pps-alignment-global-pcl
cmsbuild 5f65797
adding online dqm plots to offline dqm for data relval
jshlee 5882c72
Merge pull request #35727 from rovere/fixDeltaC_InBH
cmsbuild ded52a6
Merge pull request #35679 from CTPPS/ShiftToOrbitFrame
cmsbuild 21892a8
Merge pull request #35730 from bsunanda/Run3-sim94
cmsbuild 136dbee
Merge pull request #35737 from cvuosalo/solids-dimen-precision
cmsbuild 39c47f7
implement new comments from PR review
azotz 5bf111f
make file path retrieval more compact
azotz 0f0430f
Merge pull request #35731 from mmusich/fixDoubleDeletionsFrompoolDbSe…
cmsbuild 5fc2d46
A quick fix for the empty entries of extended FEDs
ecbefc9
Correct comments in cfg files
e5c7aaf
change capitalization of data members and functions
azotz 4c7f78a
esConsumes migration for muon alignment
hyunyong ebb99e8
apply comments
hyunyong 687591e
use edm::one class, remove intermediate ESHandle
hyunyong 56cd795
Merge pull request #35715 from pmandrik/splash_run_update_master
cmsbuild 7e93281
rebase
hyunyong 906a1fc
remove BuildFile.xml
hyunyong 4558bf8
Improve logging of BeamSpot DQM clients
francescobrivio c60bf70
Include new L1 trigger tags in Run-3 MC GTs
tvami 302916c
Use shared_ptr for MutableMonitorElementData
Dr15Jones 4dd21eb
Changes to accommodate Splash events
abhih1 01931cb
Merge pull request #35741 from lwang046/HcalDQM-FixRunSummary
cmsbuild 277ae78
Merge pull request #35722 from makortel/fixcustomisePixelLocalReconst…
cmsbuild 8178c08
Merge pull request #35719 from hyunyong/esConsumesMigPR
cmsbuild 3f8e286
Merge pull request #35721 from mmusich/noLoopers
cmsbuild 8a454ee
Using Time Average of Sending and Receiving
AliinCern ef2421c
Ran scram build code-format
AliinCern 4c0c307
Merge pull request #35749 from francescobrivio/alca-BS_debugPrintouts
cmsbuild 8411a01
Merge pull request #35739 from jshlee/gem-validation-CMSSW_12_1_0_pre3
cmsbuild edd759b
remove unused includes and data member
azotz 33367ae
improve readability
azotz e73fe94
remove description of previously removed variable
azotz 0e1ee6a
Merge pull request #35755 from abhih1/SplashEventsMaster
cmsbuild 7a62b3b
Take the Average inside a Function, Using getopt for Parsing, and add…
AliinCern 4378aa3
Merge pull request #35756 from Dr15Jones/refCounMutableMonitorElement…
cmsbuild 7846e1f
Merge pull request #35748 from tvami/InclNewL1Tag
cmsbuild db75011
Modified BuildFile.xml, and Deleted unused variables: cvalue, length,…
AliinCern f4299e6
Modified BuildFile.xml, and Deleted unused variables: cvalue, length,…
AliinCern 532d278
Merge pull request #35259 from mmusich/ConsumesMigRefTraj
cmsbuild b383d8a
Added esConsumes to HiBasicGenTest
Dr15Jones 806aaba
switch loop index to uint from uint16 in FlagsCleanerECAL
slava77 dc24f0f
Added esConsumes to MuonShowerInformationFiller
Dr15Jones fe6c114
Removed unnecessary includes
Dr15Jones 26e32b1
Modernized test modules in RecoMuon/MuonIdentification
Dr15Jones 57a62ea
try to remove the extra .cc files
387d347
import trackdnn_CKF in for Era_Run3_noMkFit
9e1488e
fix the name of the _mod
448ae25
remove dnn in the heavy ion track selection
8c9693c
fix import
77846bf
Removed unnecessary include
Dr15Jones 23347a5
Moved fetchHcalAlgoData functionality to ED modules
Dr15Jones 16173a3
Merge pull request #35640 from cms-tau-pog/CMSSW_12_1_X_tau-pog_L2wCNN
cmsbuild 41dd793
Fix deprecated warkings in RecoJets/JetProducers
Dr15Jones 8ee7488
Fix one definition rule violation in HLTriggerOffline/Muon
Dr15Jones 0206a82
Use GlobalCache in BaseMVAValueMapProducer.
hqucms 598febf
Use esConsumes for PropagateToMuon
Dr15Jones 9d32ee7
Merge pull request #35768 from slava77/patch-105
cmsbuild 727443c
solve conflict
6429b92
Enable creation of reduced material payloads
cvuosalo 024be60
Merge pull request #35704 from guitargeek/HiSuperClusterProducer_1
cmsbuild f456ae6
Merge pull request #35773 from Dr15Jones/deprecatedRecoJetsJetProducers
cmsbuild bb7090e
Merge pull request #35771 from Dr15Jones/esConsumesRecoLocalCalo
cmsbuild 5f1b571
Merge pull request #35770 from Dr15Jones/deprecatedRecoMuonMuonIdenti…
cmsbuild f84a333
fixes to copy log4cplus.properties locally when run
sikler 9609845
added line for DQM monitoring service
sikler d685cd8
fixing dip name servers
sikler 8041d41
Merge pull request #35777 from Dr15Jones/fixHLTriggerOfflineMuon
cmsbuild defa117
Merge pull request #35733 from quark2/GEM-onlineDQMForFixingBinning-1…
cmsbuild d8ebf45
modernize DQM/TrackerCommon
mmusich 9d9e37f
Merge pull request #35767 from Dr15Jones/esConsumesHiBasicGenTest
cmsbuild 06818d1
Include PPS persistent geometry in all GTs
malbouis b67b080
Switch for reading persistent PPS geometry record
malbouis 04fad7f
Simple CSC digi and TP filter for Run-3 studies
0d6dc94
Merge pull request #35780 from francescobrivio/DIPserverBeamSpot
cmsbuild 57f317d
Python3 migration fix
consuegs 904d1c2
Merge pull request #35778 from cvuosalo/reduced-material
cmsbuild 48ecde6
Merge pull request #35686 from minxiyang/MkFit-dnn
cmsbuild c0a6467
Fix CMS deprecated warnings in CommonTools/RecoAlgos
Dr15Jones ba07adb
update data GTs with PPS persistent geometry object
malbouis 131b197
Remove unnecessary include
Dr15Jones a33c405
Use esConsumes for TrackMVCalssifier instances
Dr15Jones 0a16b55
Merge pull request #35788 from consuegs/python3-migration-fix
cmsbuild ea43e07
Merge pull request #35708 from guitargeek/ptr_vector_1
cmsbuild 7356243
Merge pull request #35505 from Dr15Jones/updateStatisticsSenderService
cmsbuild 2e9fd62
Merge pull request #35782 from mmusich/modernize_DQM_TrackerCommon
cmsbuild 7a1dea8
Merge pull request #35633 from bsunanda/Run2-gex96
cmsbuild 9954513
Merge pull request #35717 from dildick/from-CMSSW_12_1_X_2021-10-15-1…
cmsbuild 73a87b4
Merge pull request #35789 from Dr15Jones/deprecatedCommonToolsRecoAlgos
cmsbuild 58b6b2b
Merge pull request #35774 from guitargeek/CommonTools_Statistics_1
cmsbuild 1315b6a
Merge pull request #35792 from Dr15Jones/esConsumesRecoTrackerFinalTr…
cmsbuild 717c100
Merge pull request #35450 from AliinCern/mpitest
cmsbuild f9defa4
use templates to simplify code
mmusich deb5fb1
update PPS geometry tag in data GTs
malbouis d4627bc
remove empty file
mmusich 9b2ef16
fix log error message
mmusich 724a53f
convert mkfit output warnings to LogInfo
slava77 df8ae5a
add 2018 fastsim workflow to the short matrix
slava77 e23f1bb
add unit tests
mmusich 48bf203
fix bug in the passed detector type
mmusich ce0ff8f
improve DetectorStateFilter, less verbosity, use run number with mixe…
mmusich 7871674
Merge pull request #35804 from slava77/patch-109
cmsbuild d8f9360
Merge pull request #35772 from malbouis/alca-PPSPersistentGeometry-12…
cmsbuild 4c706cc
Workaround / fix in 12_1_X for Issue #35805
rappoccio a3fdef3
MonitorTrackResiduals: do not apply PV compatibility cut when running…
mmusich 7bfdc71
Merge pull request #35802 from slava77/patch-108
cmsbuild 8c1e16b
Merge pull request #35809 from rappoccio/promptreco_bug_35805_12_1_X
cmsbuild 40c59a2
Merge pull request #35811 from mmusich/removeVertexCutForCosmicsResid…
cmsbuild 3d24094
Merge pull request #35808 from mmusich/modernize_DQM_TrackerCommon
cmsbuild ef18ada
Merge pull request #35736 from bsunanda/Run3-TB63
cmsbuild 5240778
Merge pull request #35698 from hqucms/dev/nano_jetReg
cmsbuild 3268720
Merged ImprovePCC from repository VinInn with cms-merge-topic
VinInn 58fd079
fix blocksize to be larger than maxpix/maxiter
VinInn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if only errors are different this is the only line that affects errors (and the one below
toCM=
).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apparently only errors are different (the tracks are the same)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how does it work, BTW? are the monitored errors unrelated to the hit uncertainties used in reconstruction of the tracks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which Tracks? Patatrack-PixelTracks use those errors in the fit (the CA does not make use of errors). Full tracking recompute the CPE (using offline Generic or Template) at each step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I meant the pixelTracks in the GPU .502 workflow (as seen in the last successful tests #35598 (comment))