make gpu Pixel Cluster Charge Cut consistent with legacy cpu version

[VinInn]

Trivial.

Small regression observed.

[VinInn]

@cmsbuild , please test

[VinInn]

enable gpu

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35525/25730

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @VinInn (Vincenzo Innocente) for master.

It involves the following packages:

• RecoLocalTracker/SiPixelClusterizer (reconstruction)

@jpata, @slava77 can you please review it and eventually sign? Thanks.
@mtosi, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @OzAmram, @ferencek, @dkotlins, @gpetruc, @mmusich, @threus, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-890f4b/19359/summary.html
COMMIT: f3aa72d
CMSSW: CMSSW_12_1_X_2021-10-03-2300/slc7_amd64_gcc900
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35525/19359/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @sroychow Migrate Egamma-Electools to use esConsumes #35444

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-890f4b/19359/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-890f4b/19359/git-merge-result

RelVals

• 11634.912

----- Begin Fatal Exception 04-Oct-2021 13:08:21 CEST-----------------------
An exception of category 'TrackingTools/PatternTools' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 9 stream: 0
   [1] Running path 'HLT_TrkMu6NoFiltersNoVtx_v1'
   [2] Calling method for module CkfTrackCandidateMaker/'hltIterL3OITrackCandidatesNoVtx'
Exception Message:
Trajectory::check() - information requested from empty Trajectory 
----- End Fatal Exception -------------------------------------------------

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19735
• DQMHistoTests: Total failures: 21
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 19714
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: no differences found

[tvami]

@cmsbuild , please test with #35493

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-890f4b/19363/summary.html
COMMIT: f3aa72d
CMSSW: CMSSW_12_1_X_2021-10-04-1100/slc7_amd64_gcc900
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35525/19363/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19735
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 19729
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: no differences found

Comparison Summary

There are some workflows for which there are errors in the baseline:
11634.912 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3008738
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3008710
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 166 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #35525 f3aa72d

• the code change is in line with the PR description. the update is now apparently consistent with the CPU version
  

  cmssw/RecoLocalTracker/SiPixelClusterizer/plugins/PixelThresholdClusterizer.cc

  Line 165 in a993d69

  if (cluster.charge() >= clusterThreshold) {

  
  as discussed in https://hypernews.cern.ch/HyperNews/CMS/get/pixelOfflineSW/1587/2/1/1/1/1/1.html
• jenkins tests pass and comparisons with the baseline show no (relevant) differences: there are small differences in the pixel GPU wf 10824.502, which look more like a case of incomplete repeatability of the result rather than from the small change in the cut introduced by this PR.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1