Include final 2021 MC DD4HEP geometry tags + new 2021 design MC beamspot GT #35514

tvami · 2021-10-03T00:04:29Z

PR description:

DD4HEP change

Include final 2021 MC DD4HEP geometry tags using the new autoCond modifier method. The new tags are explicitly visible in the code change, but for completeness they include

tag: XMLFILE_Geometry_121DD4hepV1_Extended2021_mc 
label: Extended

and

tag: TKRECO_Geometry_121DD4hepV1

as requested in [1]

[1] https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4475.html

New 2021 design MC beamspot GT

The second part of this PR is to include a new record introduced in [2] in the 2021 design MC as it was realized earlier that it was not created, see the comment [3]. The HN request can be found under [4].

The new GT and the diff wrt to the prev versioned GT are

121X_mcRun3_2021_design_v8
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021_design_v7/121X_mcRun3_2021_design_v8

They differ only in the requested tags:

  | BeamSpotOnlineHLTObjectsRcd | - | - | BeamSpotOnlineObjects_Ideal_Centered_SLHC_v3_mc
  | BeamSpotOnlineLegacyObjectsRcd | - | - | BeamSpotOnlineObjects_Ideal_Centered_SLHC_v3_mc

[2] #35373
[3] #35478 (comment)
[4] https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4474/3.html

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is not a backport but a backport to 12_0_X for the beamspot part is expected.

cc: @cms-sw/geometry-l2 @srimanob

cmsbuild · 2021-10-03T00:11:37Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35514/25720

This PR adds an extra 12KB to repository

cmsbuild · 2021-10-03T00:12:02Z

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

Configuration/AlCa (alca)

@yuanchao, @malbouis, @cmsbuild, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

tvami · 2021-10-03T00:16:47Z

test parameters:

workflows = 12034.0,11634.912

tvami · 2021-10-03T00:19:44Z

@cmsbuild , please test

cmsbuild · 2021-10-03T01:51:33Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aefadd/19345/summary.html
COMMIT: da7a5c0
CMSSW: CMSSW_12_1_X_2021-10-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35514/19345/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

11634.912

----- Begin Fatal Exception 03-Oct-2021 03:09:50 CEST-----------------------
An exception of category 'TrackingTools/PatternTools' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 9 stream: 0
   [1] Running path 'HLT_TrkMu6NoFiltersNoVtx_v1'
   [2] Calling method for module CkfTrackCandidateMaker/'hltIterL3OITrackCandidatesNoVtx'
Exception Message:
Trajectory::check() - information requested from empty Trajectory 
----- End Fatal Exception -------------------------------------------------

tvami · 2021-10-03T01:59:03Z

-1

Failed Tests: RelVals Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aefadd/19345/summary.html COMMIT: da7a5c0 CMSSW: CMSSW_12_1_X_2021-10-02-1100/slc7_amd64_gcc900 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35514/19345/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

11634.912
----- Begin Fatal Exception 03-Oct-2021 03:09:50 CEST-----------------------
An exception of category 'TrackingTools/PatternTools' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 9 stream: 0
   [1] Running path 'HLT_TrkMu6NoFiltersNoVtx_v1'
   [2] Calling method for module CkfTrackCandidateMaker/'hltIterL3OITrackCandidatesNoVtx'
Exception Message:
Trajectory::check() - information requested from empty Trajectory 
----- End Fatal Exception -------------------------------------------------

Interesting, this ran fine for 9 events, and only broke for the 10th event. @cvuosalo have you seen anything like this while locally testing these tags? Did I miss something in the autoCondModifier?

srimanob · 2021-10-03T02:55:49Z

@cmsbuild please test

Give it another try. If we somehow have a random issue, we will see it also in the production test of dd4hep.

cmsbuild · 2021-10-03T04:30:44Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aefadd/19346/summary.html
COMMIT: da7a5c0
CMSSW: CMSSW_12_1_X_2021-10-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35514/19346/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

11634.912

----- Begin Fatal Exception 03-Oct-2021 05:50:47 CEST-----------------------
An exception of category 'TrackingTools/PatternTools' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 9 stream: 0
   [1] Running path 'HLT_TrkMu6NoFiltersNoVtx_v1'
   [2] Calling method for module CkfTrackCandidateMaker/'hltIterL3OITrackCandidatesNoVtx'
Exception Message:
Trajectory::check() - information requested from empty Trajectory 
----- End Fatal Exception -------------------------------------------------

mmusich · 2021-10-03T05:05:46Z

@tvami @srimanob looks like you need to test with #35493

srimanob · 2021-10-03T07:27:07Z

@cmsbuild please test with #35493

qliphy · 2021-10-03T08:31:15Z

urgent
for 12_1_0_pre4,
see https://its.cern.ch/jira/browse/PDMVRELVALS-134

Configuration/AlCa/python/autoCond.py

cmsbuild · 2021-10-03T15:00:08Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aefadd/19347/summary.html
COMMIT: da7a5c0
CMSSW: CMSSW_12_1_X_2021-10-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35514/19347/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-aefadd/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST

Summary:

No significant changes to the logs found
Reco comparison results: 3085 differences found in the comparisons
DQMHistoTests: Total files compared: 40
DQMHistoTests: Total histograms compared: 3219394
DQMHistoTests: Total failures: 6702
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3212670
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
Checked 169 log files, 37 edm output root files, 40 DQM output files
TriggerResults: found differences in 1 / 39 workflows

tvami · 2021-10-03T15:08:09Z

Results are as expected:

changes only in 11634.912 and there we see changes everywhere which is expected due to the geometry change

francescobrivio · 2021-10-03T16:07:10Z

+alca

see comment in Include final 2021 MC DD4HEP geometry tags + new 2021 design MC beamspot GT #35514 (comment)

cmsbuild · 2021-10-03T16:07:33Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2021-10-03T19:46:51Z

+1

tvami added 2 commits October 3, 2021 01:34

Include new ideal beamspot records in Run-3 MC design GT

6114cba

Include final 2021 MC DD4HEP geometry tags

da7a5c0

cmsbuild added this to the CMSSW_12_1_X milestone Oct 3, 2021

cmsbuild added alca-pending code-checks-pending orp-pending pending-signatures tests-pending labels Oct 3, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 3, 2021

tvami mentioned this pull request Oct 3, 2021

[120X] Include new ideal beamspot records in Run-3 MC design GT #35515

Merged

cmsbuild added tests-started and removed tests-pending labels Oct 3, 2021

cmsbuild added tests-rejected and removed tests-started labels Oct 3, 2021

cmsbuild added tests-started and removed tests-rejected labels Oct 3, 2021

cmsbuild added tests-rejected and removed tests-started labels Oct 3, 2021

cmsbuild added the requires-external label Oct 3, 2021

cmsbuild added tests-started and removed tests-rejected labels Oct 3, 2021

cmsbuild added the urgent label Oct 3, 2021

srimanob reviewed Oct 3, 2021

View reviewed changes

Configuration/AlCa/python/autoCond.py Show resolved Hide resolved

cmsbuild added tests-approved and removed tests-started labels Oct 3, 2021

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Oct 3, 2021

cmsbuild added orp-approved and removed orp-pending labels Oct 3, 2021

cmsbuild merged commit c6304f6 into cms-sw:master Oct 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Include final 2021 MC DD4HEP geometry tags + new 2021 design MC beamspot GT #35514

Include final 2021 MC DD4HEP geometry tags + new 2021 design MC beamspot GT #35514

tvami commented Oct 3, 2021 •

edited

Loading

cmsbuild commented Oct 3, 2021

cmsbuild commented Oct 3, 2021

tvami commented Oct 3, 2021 •

edited

Loading

tvami commented Oct 3, 2021

cmsbuild commented Oct 3, 2021

tvami commented Oct 3, 2021

RelVals

srimanob commented Oct 3, 2021

cmsbuild commented Oct 3, 2021

mmusich commented Oct 3, 2021

srimanob commented Oct 3, 2021

qliphy commented Oct 3, 2021

cmsbuild commented Oct 3, 2021

tvami commented Oct 3, 2021

francescobrivio commented Oct 3, 2021

cmsbuild commented Oct 3, 2021

perrotta commented Oct 3, 2021

Include final 2021 MC DD4HEP geometry tags + new 2021 design MC beamspot GT #35514

Include final 2021 MC DD4HEP geometry tags + new 2021 design MC beamspot GT #35514

Conversation

tvami commented Oct 3, 2021 • edited Loading

PR description:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Oct 3, 2021

cmsbuild commented Oct 3, 2021

tvami commented Oct 3, 2021 • edited Loading

tvami commented Oct 3, 2021

cmsbuild commented Oct 3, 2021

RelVals

tvami commented Oct 3, 2021

RelVals

srimanob commented Oct 3, 2021

cmsbuild commented Oct 3, 2021

RelVals

mmusich commented Oct 3, 2021

srimanob commented Oct 3, 2021

qliphy commented Oct 3, 2021

cmsbuild commented Oct 3, 2021

Comparison Summary

tvami commented Oct 3, 2021

francescobrivio commented Oct 3, 2021

cmsbuild commented Oct 3, 2021

perrotta commented Oct 3, 2021

tvami commented Oct 3, 2021 •

edited

Loading

tvami commented Oct 3, 2021 •

edited

Loading