-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SciLayer8 4mm sipm rad max added #35500
Conversation
@suhokimHEP, CMSSW_12_1_X branch is closed for direct updates. cms-bot is going to move this PR to master branch. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35500/25682
|
A new Pull Request was created by @suhokimHEP for master. It involves the following packages:
@cmsbuild, @AdrianoDee, @civanch, @srimanob, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f6629/19312/summary.html Comparison SummarySummary:
|
@cmsbuild please test workflow 38634.0 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f6629/19323/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+1 |
+Upgrade This PR updates the mapping of sipm size as title said. The PR test run fine. |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
<For GeometryD86, it's adding the 4mm sipm for HGCal scintillator tiles in Layer8 (instead of 2mm)-->
PR validation:
<SimCalorimetry/HGCalSimAlgos/test/hgchebacksignalscaler_cfg.py with sipmMap argument>
if this PR is a backport please specify the original PR and why you need to backport that PR:
Before submitting your pull requests, make sure you followed this checklist: