-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor updates in CSC TP configurations for B904 tests #35496
Minor updates in CSC TP configurations for B904 tests #35496
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35496/25666
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35496/25668
|
A new Pull Request was created by @dildick (Sven Dildick) for master. It involves the following packages:
@cmsbuild, @rekovic, @emeschi, @cecilecaillol, @smorovic can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c14fcc/19300/summary.html Comparison SummaryThe workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons Summary:
|
+1 |
1 similar comment
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c14fcc/19487/summary.html Comparison SummarySummary:
|
+1 |
PR description:
@jfernan2 Recall that I recently closed #34780 without merging it, because I did not want to introduce additional emulator changes while we're still investigating the performance of the Run-3 trigger primitives in the forward region for high-pT muons. Nevertheless PR #34780 does have a few updates for our B904 test-stands. In particular we are testing the Run-3 firmware for ME2/1 this week (and the DMBSlot2 in currently wrong).
PR validation:
Code compiles. Only test configurations.
if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A
Before submitting your pull requests, make sure you followed this checklist: