-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update of mkFit for 12_1_0_pre4 #35492
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35492/25661 ERROR: Build errors found during clang-tidy run.
|
code-checks with cms.week0.PR_bd16d39b/52.0-e05c6c4771494e730b9d4ac54b12b03d |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35492/25673
|
A new Pull Request was created by @mmasciov (Mario Masciovecchio) for master. It involves the following packages:
@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters: |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3752eb/19304/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummaryThe workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons Summary:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the differences in the mkFit / .7 workflows as expected?
const TrackVec &in_seeds, | ||
const EventOfHits &eoh, | ||
IterationSeedPartition &part) { | ||
const int size = in_seeds.size(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const int size = in_seeds.size(); | |
const size_t size = in_seeds.size(); |
perhaps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks.
IterationSeedPartition &part) { | ||
const int size = in_seeds.size(); | ||
|
||
for (int i = 0; i < size; ++i) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for (int i = 0; i < size; ++i) { | |
for (size_t i = 0; i < size; ++i) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks.
const bool z_dir_pos = S.pz() > 0; | ||
|
||
HitOnTrack hot = S.getLastHitOnTrack(); | ||
float eta = eoh[hot.layer].GetHit(hot.index).eta(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
float eta = eoh[hot.layer].GetHit(hot.index).eta(); | |
const float eta = eoh[hot.layer].GetHit(hot.index).eta(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks.
|
||
const LayerInfo &tec_first = z_dir_pos ? tecp1 : tecn1; | ||
|
||
float maxR = S.maxReachRadius(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
float maxR = S.maxReachRadius(); | |
const float maxR = S.maxReachRadius(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks.
} | ||
|
||
part.m_region[i] = reg; | ||
part.m_sort_score[i] = 5.0f * (reg - 2) + eta; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps these magic numbers need to be put into a constexpr or clarified via a comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done: a constexpr is now used and a comment has been added to explain the point of this line. Thanks!
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35492/25740
|
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3752eb/19384/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
|
Just to note, I'm ready to sign this PR, I'm waiting for cms-data/RecoTracker-MkFit#5 and cms-sw/cmsdist#7349 to be merged before leaving the reco sig. |
in this case all 3 PRs have to be included at the same time. So, serializing the signature will not really work. |
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
PR description:
This PR follows #35199 and updates mkFit in view of CMSSW_12_1_0_pre4.
In detail, this PR includes technical update of mkFit configurations.
Via cms-sw/cmsdist#7349 and cms-data/RecoTracker-MkFit#5 it includes updates to improve tracking performance, presented in detail at the Tracker DPG - Tracking POG general meeting.
It requires cms-sw/cmsdist#7349 and cms-data/RecoTracker-MkFit#5
PR validation:
Performance has been presented in detail at the Tracker DPG - Tracking POG general meeting
Full MTV results in TTbar events with PU (Run-3, 2021) are available:
http://uaf-10.t2.ucsd.edu/~mmasciov/MkFit_devs/TrackerDPGValidation/MTV_mkFit-7iter_pre4_plusCKF_Sep27/