[DQM] Remove DQM reference histogram Rcd #35491

jfernan2 · 2021-09-30T15:11:16Z

PR description:

We are removing this old servie not used any longer as request of AlCaDb

PR validation:

Unit Test in DQM/Integration passed
runTheMatrix -l limited passed

This reverts commit 22141d3.

This reverts commit 422d8d1.

cmsbuild · 2021-09-30T15:18:39Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35491/25659

This PR adds an extra 92KB to repository
Found files with invalid states:
- CondTools/DQM/test/DQMReferenceHistogramRootFileEventSetupAnalyzer_OrcoffOnly_cfg.py:
  - Deleted: 422d8d1, 8f37387
  - Added: eac1749
- CondTools/DQM/test/DQMXMLFileEventSetupAnalyzer_cfg.py:
  - Deleted: 422d8d1, 8f37387
  - Added: eac1749
- CondTools/DQM/python/DQMReferenceHistogramRootFileEventSetupAnalyzer_OrcoffOnly_cfi.py:
  - Deleted: 422d8d1, 8f37387
  - Added: eac1749
- CondTools/DQM/python/DQMReferenceHistogramRootFileEventSetupAnalyzer_cfi.py:
  - Deleted: 422d8d1, 8f37387
  - Added: eac1749
- CondTools/DQM/plugins/DQMReferenceHistogramRootFileEventSetupAnalyzer.cc:
  - Deleted: 422d8d1, 8f37387
  - Added: eac1749
- CondTools/DQM/plugins/DQMReferenceHistogramRootFilePopConAnalyzer.cc:
  - Deleted: 422d8d1, 8f37387
  - Added: eac1749
- CondTools/DQM/src/DQMReferenceHistogramRootFileSourceHandler.cc:
  - Deleted: 422d8d1
  - Added: eac1749
- CondFormats/DataRecord/interface/DQMReferenceHistogramRootFileRcd.h:
  - Deleted: 422d8d1
  - Added: eac1749
- CondTools/DQM/interface/DQMReferenceHistogramRootFileSourceHandler.h:
  - Deleted: 422d8d1, 8f37387
  - Added: eac1749
- CondFormats/DataRecord/src/DQMReferenceHistogramRootFileRcd.cc:
  - Deleted: 422d8d1
  - Added: eac1749
- CondTools/DQM/python/DQMReferenceHistogramRootFileEventSetupAnalyzer_SQLiteOnly_cfi.py:
  - Deleted: 422d8d1, 8f37387
  - Added: eac1749

cmsbuild · 2021-09-30T15:19:20Z

A new Pull Request was created by @jfernan2 for master.

It involves the following packages:

CondTools/DQM (dqm, db)
DQM/Integration (dqm)
DQMOffline/Muon (dqm)

@malbouis, @pmandrik, @emanueleusai, @ahmad3213, @rvenditti, @cmsbuild, @jfernan2, @ggovi, @francescobrivio, @pbo0, @tvami can you please review it and eventually sign? Thanks.
@sscruz, @barvic, @batinkov, @battibass, @threus, @abbiendi, @jhgoh, @calderona, @cericeci, @HuguesBrun, @Fedespring, @ptcox, @mmusich, @rociovilar, @trocino, @bellan, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

jfernan2 · 2021-09-30T15:20:48Z

please test

tvami · 2021-09-30T15:30:24Z

@jfernan2

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35491/25659

This PR adds an extra 92KB to repository

Found files with invalid states:

CondTools/DQM/test/DQMReferenceHistogramRootFileEventSetupAnalyzer_OrcoffOnly_cfg.py:

Deleted: 422d8d1, 8f37387

Added: eac1749

CondTools/DQM/test/DQMXMLFileEventSetupAnalyzer_cfg.py:

Deleted: 422d8d1, 8f37387

Added: eac1749

CondTools/DQM/python/DQMReferenceHistogramRootFileEventSetupAnalyzer_OrcoffOnly_cfi.py:

Deleted: 422d8d1, 8f37387

Added: eac1749

CondTools/DQM/python/DQMReferenceHistogramRootFileEventSetupAnalyzer_cfi.py:

Deleted: 422d8d1, 8f37387

Added: eac1749

CondTools/DQM/plugins/DQMReferenceHistogramRootFileEventSetupAnalyzer.cc:

Deleted: 422d8d1, 8f37387

Added: eac1749

CondTools/DQM/plugins/DQMReferenceHistogramRootFilePopConAnalyzer.cc:

Deleted: 422d8d1, 8f37387

Added: eac1749

CondTools/DQM/src/DQMReferenceHistogramRootFileSourceHandler.cc:

Deleted: 422d8d1

Added: eac1749

CondFormats/DataRecord/interface/DQMReferenceHistogramRootFileRcd.h:

Deleted: 422d8d1

Added: eac1749

CondTools/DQM/interface/DQMReferenceHistogramRootFileSourceHandler.h:

Deleted: 422d8d1, 8f37387

Added: eac1749

CondFormats/DataRecord/src/DQMReferenceHistogramRootFileRcd.cc:

Deleted: 422d8d1

Added: eac1749

CondTools/DQM/python/DQMReferenceHistogramRootFileEventSetupAnalyzer_SQLiteOnly_cfi.py:

Deleted: 422d8d1, 8f37387

Added: eac1749

@jfernan2 would you please consider squashing the commits that delete and add these files? Just to get rid of these "virtual" change msg-s above.

cmsbuild · 2021-09-30T15:32:59Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b8755b/19292/summary.html
COMMIT: 8f37387
CMSSW: CMSSW_12_1_X_2021-09-30-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35491/19292/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-30-1100/src/CondTools/DQM/src/DQMSummarySourceHandler.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-30-1100/src/CondTools/DQM/src/ReadBase.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-30-1100/src/CondTools/DQM/src/DQMXMLFileSourceHandler.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-30-1100/src/CondTools/DQM/src/TestBase.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-30-1100/src/CondTools/DQM/src/DQMReferenceHistogramRootFileSourceHandler.cc:1:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-30-1100/poison/CondTools/DQM/interface/DQMReferenceHistogramRootFileSourceHandler.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
    1 | #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
      |  ^~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-09-30-1100/src/CondTools/DQM/src/DQMReferenceHistogramRootFileSourceHandler.cc:10:3: error: 'DQMReferenceHistogramRootFileSourceHandler' does not name a type
   10 |   DQMReferenceHistogramRootFileSourceHandler::DQMReferenceHistogramRootFileSourceHandler(const edm::ParameterSet& pset)
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tvami · 2021-09-30T16:02:35Z

I think CondTools/DQM/src/DQMReferenceHistogramRootFileSourceHandler.cc can be removed too

https://github.com/jfernan2/cmssw into removeDQMReferenceHistogram

jfernan2 · 2021-10-01T11:27:52Z

please test

mmusich · 2021-10-01T11:30:12Z

unassign trk-dpg

thanks @jfernan2

cmsbuild · 2021-10-01T11:49:49Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35491/25692

This PR adds an extra 96KB to repository
Found files with invalid states:
- CondTools/DQM/test/DQMReferenceHistogramRootFileEventSetupAnalyzer_OrcoffOnly_cfg.py:
  - Deleted: 422d8d1, 8f37387, 3fddef9
  - Added: eac1749
- CondTools/DQM/test/DQMXMLFileEventSetupAnalyzer_cfg.py:
  - Deleted: 422d8d1, 8f37387, 3fddef9
  - Added: eac1749, 61666d6
- CondTools/DQM/python/DQMReferenceHistogramRootFileEventSetupAnalyzer_OrcoffOnly_cfi.py:
  - Deleted: 422d8d1, 8f37387, 3fddef9
  - Added: eac1749
- CondTools/DQM/python/DQMReferenceHistogramRootFileEventSetupAnalyzer_cfi.py:
  - Deleted: 422d8d1, 8f37387, 3fddef9
  - Added: eac1749
- CondTools/DQM/plugins/DQMReferenceHistogramRootFileEventSetupAnalyzer.cc:
  - Deleted: 422d8d1, 8f37387, 3fddef9
  - Added: eac1749
- CondTools/DQM/plugins/DQMReferenceHistogramRootFilePopConAnalyzer.cc:
  - Deleted: 422d8d1, 8f37387, 3fddef9
  - Added: eac1749
- CondTools/DQM/src/DQMReferenceHistogramRootFileSourceHandler.cc:
  - Deleted: 422d8d1, 450ca7d
  - Added: eac1749
- CondFormats/DataRecord/interface/DQMReferenceHistogramRootFileRcd.h:
  - Deleted: 422d8d1
  - Added: eac1749
- CondTools/DQM/interface/DQMReferenceHistogramRootFileSourceHandler.h:
  - Deleted: 422d8d1, 8f37387, 3fddef9
  - Added: eac1749
- CondFormats/DataRecord/src/DQMReferenceHistogramRootFileRcd.cc:
  - Deleted: 422d8d1
  - Added: eac1749
- CondTools/DQM/python/DQMReferenceHistogramRootFileEventSetupAnalyzer_SQLiteOnly_cfi.py:
  - Deleted: 422d8d1, 8f37387, 3fddef9
  - Added: eac1749

cmsbuild · 2021-10-01T11:50:09Z

Pull request #35491 was updated. @malbouis, @pmandrik, @emanueleusai, @ahmad3213, @rvenditti, @jfernan2, @ggovi, @francescobrivio, @pbo0, @tvami can you please check and sign again.

cmsbuild · 2021-10-01T15:04:44Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b8755b/19316/summary.html
COMMIT: 61666d6
CMSSW: CMSSW_12_1_X_2021-09-30-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35491/19316/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 40
DQMHistoTests: Total histograms compared: 3211080
DQMHistoTests: Total failures: 11
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3211046
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 39 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 169 log files, 37 edm output root files, 40 DQM output files
TriggerResults: no differences found

jfernan2 · 2021-10-01T15:06:44Z

+1

ggovi · 2021-10-04T07:37:16Z

+1

cmsbuild · 2021-10-04T07:37:39Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-10-05T01:35:01Z

+1

jfernan2 added 5 commits September 30, 2021 10:56

Remove DQMReferenceHistogramRootFile

422d8d1

Bring plugin back

22141d3

Revert "Bring plugin back"

19a54ef

This reverts commit 22141d3.

Revert "Remove DQMReferenceHistogramRootFile"

eac1749

This reverts commit 422d8d1.

Remove DQMReferenceHistogram

8f37387

cmsbuild added this to the CMSSW_12_1_X milestone Sep 30, 2021

cmsbuild added code-checks-pending db-pending dqm-pending orp-pending pending-signatures tests-pending labels Sep 30, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 30, 2021

cmsbuild added tests-started and removed tests-pending labels Sep 30, 2021

cmsbuild added tests-rejected and removed tests-started labels Sep 30, 2021

jfernan2 added 3 commits September 30, 2021 22:00

Remove DQMReferenceHistogramRootFile

3fddef9

Remove DQMReferenceHistogramRootFileSourceHandle

450ca7d

Merge branch 'removeDQMReferenceHistogram' of

22c5b1f

https://github.com/jfernan2/cmssw into removeDQMReferenceHistogram

cmsbuild added code-checks-pending and removed tests-rejected code-checks-approved labels Sep 30, 2021

cmsbuild added code-checks-pending tests-pending trk-dpg-pending labels Oct 1, 2021

cmsbuild added tests-started and removed tests-pending labels Oct 1, 2021

cmsbuild removed the trk-dpg-pending label Oct 1, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 1, 2021

cmsbuild added tests-approved and removed tests-started labels Oct 1, 2021

cmsbuild added dqm-approved and removed dqm-pending labels Oct 1, 2021

tvami mentioned this pull request Oct 3, 2021

Remove DQMReferenceHistogramRootFileRcd from GTs cms-AlCaDB/AlCaTools#40

Closed

cmsbuild added db-approved fully-signed and removed db-pending pending-signatures labels Oct 4, 2021

tvami mentioned this pull request Oct 4, 2021

Remove DQMReferenceHistogramRootFileRcd from all GTs #35533

Merged

cmsbuild added orp-approved and removed orp-pending labels Oct 5, 2021

cmsbuild merged commit e3fb6ef into cms-sw:master Oct 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DQM] Remove DQM reference histogram Rcd #35491

[DQM] Remove DQM reference histogram Rcd #35491

jfernan2 commented Sep 30, 2021

cmsbuild commented Sep 30, 2021

cmsbuild commented Sep 30, 2021

jfernan2 commented Sep 30, 2021

tvami commented Sep 30, 2021

cmsbuild commented Sep 30, 2021

tvami commented Sep 30, 2021

jfernan2 commented Oct 1, 2021

mmusich commented Oct 1, 2021

cmsbuild commented Oct 1, 2021

cmsbuild commented Oct 1, 2021

cmsbuild commented Oct 1, 2021

jfernan2 commented Oct 1, 2021

ggovi commented Oct 4, 2021

cmsbuild commented Oct 4, 2021

qliphy commented Oct 5, 2021

[DQM] Remove DQM reference histogram Rcd #35491

[DQM] Remove DQM reference histogram Rcd #35491

Conversation

jfernan2 commented Sep 30, 2021

PR description:

PR validation:

cmsbuild commented Sep 30, 2021

cmsbuild commented Sep 30, 2021

jfernan2 commented Sep 30, 2021

tvami commented Sep 30, 2021

cmsbuild commented Sep 30, 2021

Build

tvami commented Sep 30, 2021

jfernan2 commented Oct 1, 2021

mmusich commented Oct 1, 2021

cmsbuild commented Oct 1, 2021

cmsbuild commented Oct 1, 2021

cmsbuild commented Oct 1, 2021

Comparison Summary

jfernan2 commented Oct 1, 2021

ggovi commented Oct 4, 2021

cmsbuild commented Oct 4, 2021

qliphy commented Oct 5, 2021