[HGCAL trigger] Migrate to esConsumes

[jbsauvan]

PR description:

• Part of Migrate ED modules to use esConsumes #31061
• Migrate to use esConsumes for modules in L1Trigger/L1THGCal and L1Trigger/L1THGCalUtilities

PR validation:

Private tests in L1Trigger/L1THGCalUtilities/test:

cmsRun testHGCalL1T_RelValV11_cfg.py

Tested D49, D60 and D68 workflows

runTheMatrix.py -w upgrade -l 23234.0 --maxSteps=2 
runTheMatrix.py -w upgrade -l 28234.0 --maxSteps=2 
runTheMatrix.py -w upgrade -l 31434.0 --maxSteps=2

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35459/25615

• This PR adds an extra 68KB to repository

[makortel]

Thanks!

[cmsbuild]

A new Pull Request was created by @jbsauvan (Jean-Baptiste Sauvan) for master.

It involves the following packages:

• L1Trigger/L1THGCal (upgrade, l1)
• L1Trigger/L1THGCalUtilities (upgrade, l1)

@cmsbuild, @AdrianoDee, @srimanob, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @amarini, @lgray this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[srimanob]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cab02a/19216/summary.html
COMMIT: 0344ed8
CMSSW: CMSSW_12_1_X_2021-09-28-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35459/19216/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 2 EventSetupRecord::get warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cab02a/19216/llvm-analysis/esrget-sa.txt for details.
CMS StaticAnalyzer warnings: There are 1 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cab02a/19216/llvm-analysis/legacy-mod-sa.txt for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3211080
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3211052
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 39 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[jbsauvan]

Seems that I forgot to migrate L1Trigger/L1THGCalUtilities/plugins/CaloTruthCellsProducer.cc, I'll update it.

There is still a deprecated call of EventSetupRecord::get(ESHandle&) in L1Trigger/L1THGCal/src/HGCalTriggerTools.cc, but this was kept because the HGCalTriggerTools::eventSetup function that makes this call is used outside L1THGCal packages in L1Trigger/L1CaloTrigger/test

[makortel]

There is still a deprecated call of EventSetupRecord::get(ESHandle&) in L1Trigger/L1THGCal/src/HGCalTriggerTools.cc, but this was kept because the HGCalTriggerTools::eventSetup function that makes this call is used outside L1THGCal packages in L1Trigger/L1CaloTrigger/test

That call needs to be eventually migrated as well. Is the code in L1Trigger/L1CaloTrigger/test being run as part of unit tests (scram b runtests)? If yes, addressing it rather soon would be appreciated (still a separate PR would be fine).

[jbsauvan]

There is still a deprecated call of EventSetupRecord::get(ESHandle&) in L1Trigger/L1THGCal/src/HGCalTriggerTools.cc, but this was kept because the HGCalTriggerTools::eventSetup function that makes this call is used outside L1THGCal packages in L1Trigger/L1CaloTrigger/test

That call needs to be eventually migrated as well. Is the code in L1Trigger/L1CaloTrigger/test being run as part of unit tests (scram b runtests)? If yes, addressing it rather soon would be appreciated (still a separate PR would be fine).

Unfortunately I cannot tell as I'm not responsible of this part (which is why I didn't want to modify the code there). Maybe @cecilecaillol and @rekovic know who in the L1T group could have a look.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35459/25638

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #35459 was updated. @cmsbuild, @AdrianoDee, @srimanob, @cecilecaillol, @rekovic can you please check and sign again.

[makortel]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cab02a/19252/summary.html
COMMIT: 97ceaf1
CMSSW: CMSSW_12_1_X_2021-09-28-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35459/19252/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 1 EventSetupRecord::get warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cab02a/19252/llvm-analysis/esrget-sa.txt for details.
CMS StaticAnalyzer warnings: There are 1 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cab02a/19252/llvm-analysis/legacy-mod-sa.txt for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3211080
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3211052
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 39 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[rekovic]

+1

[rekovic]

@markotel

#35459 (comment)

No, the code in L1Trigger/L1CaloTrigger/test is not run as part of unit tests.

[makortel]

@cms-sw/upgrade-l2 Could you please review and sign? Thanks!

[AdrianoDee]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1
A deprecated call of EventSetupRecord::get(ESHandle&) in L1Trigger/L1THGCal/src/HGCalTriggerTools.cc will be fixed in a separate PR.