-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
O2O test setup modified to work across boost version changes #35440
O2O test setup modified to work across boost version changes #35440
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35440/25582
|
A new Pull Request was created by @ggovi for master. It involves the following packages:
@ggovi, @malbouis, @cmsbuild, @tvami, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35440/25583
|
please test |
CondCore/Utilities/scripts/conddb
Outdated
if timeType=='Run': | ||
return time[0] | ||
elif timeType=='Run': | ||
return time[1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these supposed to be both timeType == 'Run'
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really! It is not relevant for the above issue (all O2Os populates either run or timestamp tags), but definitely logically wrong.
test parameters:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35440/25599
|
please test |
test parameters: addpkg = CondTools |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53e808/19193/summary.html Comparison SummarySummary:
|
+db |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@tvami a bit too fast :-) |
The backport #35442 has far many more changes than the few lines that were coded here. Does the fix relate to those extra lines, or the ones in common? |
@perrotta Ah, right: the extra changes already appearing in 10_6_X are coming from the code-checks + code-format, that was already executed here in the master! The new fix will be totally unrelated. So - do I understand correctly:
Please confirm! |
Correct @ggovi , please proceed |
PR description:
The workflows of integration tests for most of the O2Os are currently executed on special sqlite exports of the concerned production Tags, where only the second-last iov is copied. This choice, implemented with the command "conddb copy --o2oTest", allows to limit the execution time of the O2O workflow to a reasonable time. However, the present implementation fails when the second-last iov points to a payload produced with a boost release incompatible (=more recent) with the underlying release boost version. Typically, this happening in CMSSW branches that are left behind with respect to the last release used in production for the O2Os.
This problem is the cause of issue #33989
To overcome the problem, the o2oTest option of the function conddb copy has been modified, to select the highest iov in the source tag, pointing to a payload with boost version compatible with the underlying CMSSW release.
The new implementation fixes the above issue.