-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport of fixes on PPS geometry #35391
Conversation
…new position for pixel sensors
…ort, enlarged Envelop, and new position of pixel sensors
…d position w.r.t. bottom foil
A new Pull Request was created by @diemort (Gustavo Silveira) for CMSSW_12_0_X. It involves the following packages:
@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
Pull request #35391 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please check and sign again. |
Pull request #35391 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please check and sign again. |
Remaining dict2021 files removed. |
@diemort You should not have deleted those files - just substitute the ones from CMSSW_RELEASE_BASE area |
Those files were there in the release base and let them stay as they were like dict2021 |
Pull request #35391 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef5e8e/18879/summary.html Comparison SummarySummary:
|
+1 |
urgent |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
backport of #35380 |
+1
|
PR description:
This is a backport of #35380 to CMSSW_12_0_1.
This PR addresses a few minor corrections on the PPS geometry in the Pixel sensors and complies the material names in the reco geometry as stated in #34927. The position of the Silicon wafers has been move down to 250um w.r.t. the bottom foil and the envelopes with sensors ad flexible cables has been enlarged to avoid volume overlaps. Besides, the U shape of the Aluminum supports has been changed to a plain squared piece. A detailed list of the file changes and visualization of the new changes in the Pixel sensors is given in this twiki.
Includes updated on both DDD and dd4hep files and keeps the default dict2021Geometry.py for 12_0.
PR validation:
The new changes in the geometry have been validated with the full CMS geometry dump for visualization and overlap check with tolerance 0.01, plus direct and full simulation to confirm hits in both pixel and timing detectors. The position of the pixel sensors have been checked with direct simulation here.
if this PR is a backport please specify the original PR and why you need to backport that PR:
PR #35380, needed to update PPS geometry for Run3.
All changes follow the Naming Rules for new XML files in geometry.
All workflow tests done.
FYI @fabferro @jan-kaspar