-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removal of DTRecoUncertaintiesRcd
from all GTs
#35386
Conversation
Removal of DTRecoConditionsUncertRcd from All GTs
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35386/25481
|
A new Pull Request was created by @tvami (Tamas Vami) for master. It involves the following packages:
@yuanchao, @malbouis, @cmsbuild, @tvami, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
@cmsbuild , please test |
@tvami we should probably include |
Good point |
test parameters:
|
@namapane @cms-sw/dqm-l2 The following two unit tests failed
with this error
|
there's also plenty of failures in the HLT tests: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3298b2/18866/addOnTests/runall-report.log e.g. |
Yes it seems like when |
Oh I think I see what's happening... |
-1 Failed Tests: UnitTests RelVals AddOn Unit TestsI found errors in the following unit tests: ---> test TestDQMOnlineClient-dt_dqm_sourceclient had ERRORS ---> test TestDQMOnlineClient-dt4ml_dqm_sourceclient had ERRORS RelVals
Expand to see more relval errors ...
AddOn Tests
|
DTRecoUncertaintiesRcd
from all GTs
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35386/25490
|
I've updated the GTs, the PR title, the PR description (and notified the HN) |
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3298b2/18872/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
Right... the two are named confusingly similarly and indeed I put the wrong one in the subject (while, ironically, I warned about possible confusion in the body...) |
+alca |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Removal of
DTRecoUncertaintiesRcd
from all GTsPR description:
The obsolete record of
DTRecoUncertaintiesRcd
was removed from all 12_1_X GTs. Request can be seen in the HN msg of [1] and the diffs between the previous and new GTs in [2], as expected it's only in thisDTRecoUncertaintiesRcd
record. Please note that there is a +2 in the version numbering, that is because first the wrong record was removed. I kept the commit for historical reasons.[1]
https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4461.html
[2]
Diff GT - New GT
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun1_design_v2/121X_mcRun1_design_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun1_realistic_v2/121X_mcRun1_realistic_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun1_HeavyIon_v2/121X_mcRun1_HeavyIon_v5
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun2_startup_v2/121X_mcRun2_startup_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun2_asymptotic_l1stage1_v2/121X_mcRun2_asymptotic_l1stage1_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun2_design_v2/121X_mcRun2_design_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun2_asymptotic_preVFP_v2/121X_mcRun2_asymptotic_preVFP_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun2_asymptotic_v2/121X_mcRun2_asymptotic_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun2cosmics_asymptotic_deco_v2/121X_mcRun2cosmics_asymptotic_deco_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun2_HeavyIon_v2/121X_mcRun2_HeavyIon_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun2_pA_v2/121X_mcRun2_pA_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_dataRun2_v2/121X_dataRun2_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_dataRun2_HEfail_v2/121X_dataRun2_HEfail_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_dataRun2_relval_v2/121X_dataRun2_relval_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_dataRun2_PromptLike_HI_v2/121X_dataRun2_PromptLike_HI_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_dataRun3_HLT_v2/121X_dataRun3_HLT_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_dataRun2_HLT_relval_v2/121X_dataRun2_HLT_relval_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_dataRun3_Express_v2/121X_dataRun3_Express_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_dataRun3_Prompt_v2/121X_dataRun3_Prompt_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_dataRun3_v2/121X_dataRun3_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mc2017_design_v2/121X_mc2017_design_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mc2017_realistic_v2/121X_mc2017_realistic_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mc2017_realistic_forppRef5TeV_v2/120X_mc2017_realistic_forppRef5TeV_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mc2017cosmics_realistic_deco_v2/121X_mc2017cosmics_realistic_deco_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mc2017cosmics_realistic_peak_v2/121X_mc2017cosmics_realistic_peak_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_upgrade2018_design_v2/121X_upgrade2018_design_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_upgrade2018_realistic_v2/121X_upgrade2018_realistic_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_upgrade2018_realistic_RD_v2/121X_upgrade2018_realistic_RD_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_upgrade2018_realistic_HI_v2/121X_upgrade2018_realistic_HI_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_upgrade2018_realistic_HEfail_v2/121X_upgrade2018_realistic_HEfail_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_upgrade2018cosmics_realistic_deco_v4/121X_upgrade2018cosmics_realistic_deco_v6
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_upgrade2018cosmics_realistic_peak_v2/121X_upgrade2018cosmics_realistic_peak_v4
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021_design_v4/121X_mcRun3_2021_design_v6
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021_realistic_v5/121X_mcRun3_2021_realistic_v7
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021cosmics_realistic_deco_v5/121X_mcRun3_2021cosmics_realistic_deco_v7
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021_realistic_HI_v5/121X_mcRun3_2021_realistic_HI_v7
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2023_realistic_v4/121X_mcRun3_2023_realistic_v6
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2024_realistic_v4/121X_mcRun3_2024_realistic_v6
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun4_realistic_v2/121X_mcRun4_realistic_v4
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport and no backport is needed.
cc. @namapane
resolves cms-AlCaDB/AlCaTools#23