-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-trk09A Modify run21 version tracker flat minus05percent material files by taking care of multiple occurrence of materials in the definition of composite materials #35384
Conversation
…king care of multiple occurrence of materials in the definition of composite materials
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35384/25476
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a87b31/18862/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
'Top:qqbar2ttbar = on ', | ||
'6:m0 = 175 ' | ||
), | ||
pythia8CP5Settings = cms.vstring( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bsunanda For "pythia8CP5settings" and "pythia8CommonSettings" below, you may simply load the cfg in refer to e.g.
https://github.com/cms-sw/cmssw/blob/master/Configuration/Generator/python/TTbar_14TeV_TuneCP5_cfi.py#L20-L21
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35384/25500
|
Pull request #35384 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again. |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a87b31/18882/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Modify run21 version tracker flat minus05percent material files by taking care of multiple occurrence of materials in the definition of composite materials
PR validation:
Use the cfg's in Geometry/TrackerCommonData/test/python
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not sure if this needs to be back ported to 12_0_X