Fixing collection for producing unprefirable bit in NANO (master) #35294

lathomas · 2021-09-15T19:32:37Z

PR description:

The L1 unprefirable bit ("L1_UnprefireableEvent") is currently always false in NANOAOD. This is found to be due to the wrong input collection being provided to the dedicated producer.

This PR corrects this.

PR validation:

Ran on a few unprefirable data events previously identified and checked that the boolean is now true.
Checked that MC is not affected.

cmsbuild · 2021-09-15T19:40:05Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35294/25303

This PR adds an extra 20KB to repository

cmsbuild · 2021-09-15T19:43:39Z

A new Pull Request was created by @lathomas for master.

It involves the following packages:

PhysicsTools/NanoAOD (xpog)

@cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @swertz this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

mariadalfonso · 2021-09-15T21:50:35Z

please test

cmsbuild · 2021-09-15T23:09:39Z

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8fa724/18645/summary.html
COMMIT: fceae16
CMSSW: CMSSW_12_1_X_2021-09-14-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35294/18645/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

1325.81

----- Begin Fatal Exception 16-Sep-2021 00:18:14 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 3 stream: 0
   [1] Running path 'NANOEDMAODSIMoutput_step'
   [2] Prefetching for module PoolOutputModule/'NANOEDMAODSIMoutput'
   [3] Calling method for module L1TriggerResultsConverter/'l1bits'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: BXVector<GlobalExtBlk>
Looking for module label: simGtExtUnprefireable
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

1330.0

----- Begin Fatal Exception 16-Sep-2021 00:26:04 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'NANOEDMAODSIMoutput_step'
   [2] Prefetching for module PoolOutputModule/'NANOEDMAODSIMoutput'
   [3] Calling method for module L1TriggerResultsConverter/'l1bits'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: BXVector<GlobalExtBlk>
Looking for module label: simGtExtUnprefireable
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

10042.0

----- Begin Fatal Exception 16-Sep-2021 00:31:44 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'NANOEDMAODSIMoutput_step'
   [2] Prefetching for module PoolOutputModule/'NANOEDMAODSIMoutput'
   [3] Calling method for module L1TriggerResultsConverter/'l1bits'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: BXVector<GlobalExtBlk>
Looking for module label: simGtExtUnprefireable
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

136.8522136.8522_RunJetHT2018A_nanoUL+RunJetHT2018A_nanoUL+NANOEDM2018_106Xv1+HARVESTNANOAOD2018_106Xv1/step2_RunJetHT2018A_nanoUL+RunJetHT2018A_nanoUL+NANOEDM2018_106Xv1+HARVESTNANOAOD2018_106Xv1.log
1325.611325.61_TTbar_13_106Xv1NanoAODINPUT+TTbar_13_106Xv1NanoAODINPUT+NANOAODMC2017_106XMiniAODv1/step2_TTbar_13_106Xv1NanoAODINPUT+TTbar_13_106Xv1NanoAODINPUT+NANOAODMC2017_106XMiniAODv1.log
1325.811325.81_TTbar_13_106Xv1NanoAODINPUT+TTbar_13_106Xv1NanoAODINPUT+NANOEDMMC2017_106XMiniAODv1+HARVESTNANOAODMC2017_106XMiniAODv1/step2_TTbar_13_106Xv1NanoAODINPUT+TTbar_13_106Xv1NanoAODINPUT+NANOEDMMC2017_106XMiniAODv1+HARVESTNANOAODMC2017_106XMiniAODv1.log

cmsbuild · 2021-09-16T09:16:55Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35294/25318

This PR adds an extra 24KB to repository

cmsbuild · 2021-09-16T09:17:15Z

Pull request #35294 was updated. @cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please check and sign again.

gouskos · 2021-09-16T11:48:23Z

please test

cmsbuild · 2021-09-16T14:52:07Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8fa724/18658/summary.html
COMMIT: 3c42a85
CMSSW: CMSSW_12_1_X_2021-09-16-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35294/18658/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 3 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3000833
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3000805
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

lathomas · 2021-09-23T08:12:49Z

kind ping @gouskos @mariadalfonso. We then need a backport to 106X, would appreciate if someone else can take care of it !
FYI @rekovic @BenjaminRS

lathomas · 2021-09-30T09:51:17Z

Kind ping. @mariadalfonso @gouskos

mariadalfonso · 2021-11-22T17:24:42Z

please test

(re-running with recent release, ready to merge)

cmsbuild · 2021-11-22T20:38:48Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8fa724/20682/summary.html
COMMIT: 3c42a85
CMSSW: CMSSW_12_2_X_2021-11-22-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35294/20682/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 42
DQMHistoTests: Total histograms compared: 3247021
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3246999
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
Checked 177 log files, 37 edm output root files, 42 DQM output files
TriggerResults: no differences found

mariadalfonso · 2021-11-22T21:30:51Z

+xpog

cmsbuild · 2021-11-22T21:31:11Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2021-11-23T14:03:48Z

+1

Fixing collection for producing unprefirable bit in NANO (master)

fceae16

cmsbuild added this to the CMSSW_12_1_X milestone Sep 15, 2021

cmsbuild added code-checks-pending orp-pending pending-signatures tests-pending xpog-pending labels Sep 15, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 15, 2021

cmsbuild added tests-started and removed tests-pending labels Sep 15, 2021

mariadalfonso mentioned this pull request Sep 15, 2021

new features for V10 nanoAOD cms-nanoAOD/cmssw#580

Closed

39 tasks

cmsbuild added tests-rejected and removed tests-started labels Sep 15, 2021

Protection against missing collection

3c42a85

cmsbuild added code-checks-pending tests-pending and removed tests-rejected code-checks-approved labels Sep 16, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 16, 2021

cmsbuild added tests-started and removed tests-pending labels Sep 16, 2021

cmsbuild added tests-approved and removed tests-started labels Sep 16, 2021

mariadalfonso mentioned this pull request Sep 27, 2021

Generator Filter Efficiencies in NanoAOD cms-nanoAOD/cmssw#376

Closed

smuzaffar modified the milestones: CMSSW_12_1_X, CMSSW_12_2_X Oct 29, 2021

cmsbuild added tests-started and removed tests-approved labels Nov 22, 2021

cmsbuild added tests-approved and removed tests-started labels Nov 22, 2021

cmsbuild removed pending-signatures xpog-pending labels Nov 22, 2021

cmsbuild added fully-signed xpog-approved labels Nov 22, 2021

cmsbuild added orp-approved and removed orp-pending labels Nov 23, 2021

cmsbuild merged commit bdfb587 into cms-sw:master Nov 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing collection for producing unprefirable bit in NANO (master) #35294

Fixing collection for producing unprefirable bit in NANO (master) #35294

lathomas commented Sep 15, 2021

cmsbuild commented Sep 15, 2021

cmsbuild commented Sep 15, 2021

mariadalfonso commented Sep 15, 2021

cmsbuild commented Sep 15, 2021

cmsbuild commented Sep 16, 2021

cmsbuild commented Sep 16, 2021

gouskos commented Sep 16, 2021

cmsbuild commented Sep 16, 2021

lathomas commented Sep 23, 2021

lathomas commented Sep 30, 2021

mariadalfonso commented Nov 22, 2021

cmsbuild commented Nov 22, 2021

mariadalfonso commented Nov 22, 2021

cmsbuild commented Nov 22, 2021

perrotta commented Nov 23, 2021

Fixing collection for producing unprefirable bit in NANO (master) #35294

Fixing collection for producing unprefirable bit in NANO (master) #35294

Conversation

lathomas commented Sep 15, 2021

PR description:

PR validation:

cmsbuild commented Sep 15, 2021

cmsbuild commented Sep 15, 2021

mariadalfonso commented Sep 15, 2021

cmsbuild commented Sep 15, 2021

RelVals

RelVals-INPUT

cmsbuild commented Sep 16, 2021

cmsbuild commented Sep 16, 2021

gouskos commented Sep 16, 2021

cmsbuild commented Sep 16, 2021

Comparison Summary

lathomas commented Sep 23, 2021

lathomas commented Sep 30, 2021

mariadalfonso commented Nov 22, 2021

cmsbuild commented Nov 22, 2021

Comparison Summary

mariadalfonso commented Nov 22, 2021

cmsbuild commented Nov 22, 2021

perrotta commented Nov 23, 2021