-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CondDBFW to Python3 #35268
Update CondDBFW to Python3 #35268
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35268/25254
|
A new Pull Request was created by @Dres90 (Andrés Cárdenas) for master. It involves the following packages:
@ggovi, @malbouis, @cmsbuild, @tvami, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-237440/18597/summary.html Comparison SummaryThe workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons Summary:
|
Diff in the comparison are just due to "The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline". Unit tests pass nicely, I think that is the real test of this PR anyway, right @ggovi ? |
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-237440/18728/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Update CondDBFW to Python3
The new conditions uploader uses the CondDBFW mini framework in CMSSW to locally validate the Conditions DB files and lighten the load on the server. Since the Python version for CMSSW has been updated, this functionality was broken. This PR updates CondDBFW to Python3 and restores the uploadConditions_v2.py script functionality.
PR validation:
Multiple uploads have been run with this new CondDBFW to the PREP database and they have all been successful. This Python 3 code is already in use in the server side.