Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Add fake alignment to tracker geometry test #35198

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Sep 8, 2021

PR description:

Backport of #35119
This backport will be needed, to avoid crash on geometry unit test when geometry reco config is updated in #35187

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2021

A new Pull Request was created by @srimanob (Phat Srimanobhas) for CMSSW_12_0_X.

It involves the following packages:

  • Geometry/TrackerGeometryBuilder (geometry)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@JanFSchulte, @VinInn, @bsunanda, @mmusich, @mtosi, @fabiocos, @venturia this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

srimanob commented Sep 8, 2021

@cmsbuild please test

@srimanob srimanob changed the title 120 add fake alignment to tracker geometry test [Backport] Add fake alignment to tracker geometry test Sep 8, 2021
@cvuosalo
Copy link
Contributor

cvuosalo commented Sep 8, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Sep 9, 2021

please abort
(seems to be stuck)

@qliphy
Copy link
Contributor

qliphy commented Sep 9, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f4f1ba/18456/summary.html
COMMIT: 503319a
CMSSW: CMSSW_12_0_X_2021-09-09-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35198/18456/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2998536
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@qliphy
Copy link
Contributor

qliphy commented Sep 10, 2021

+1

@cmsbuild cmsbuild merged commit 851de30 into cms-sw:CMSSW_12_0_X Sep 10, 2021
@srimanob srimanob deleted the 120_AddFakeAlignmentToTrackerGeometryTest branch September 10, 2021 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants