-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TrackerAdditionalParametersPerDet_cfi to prevent exception in Tracker test script #35183
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35183/25120
|
A new Pull Request was created by @cvuosalo (Carl Vuosalo) for master. It involves the following packages:
@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
type bugfix |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3936c5/18372/summary.html Comparison SummaryThe workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons Summary:
|
The comparison test differences are not related to this PR, which doesn't change any workflow. The differences were just due to a glitch in wf 140.53 picking up different input files. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR #34120 made the
TrackerAdditionalParametersPerDet
required for Run 2 and later Tracker configs. ThetestTrackerModuleInfoDDD_cfg.py
config uses Run 1 by default, but it can also be used for later runs. Without the fix in this PR, this config encounters an exception if used for Run 2 or later.PR validation:
The config runs successfully with this PR.
This PR should be backported to 12_0 because the config fixed in this PR is needed for validating geometry DB payloads, which will be needed for 12_0.