PPS: preparation for 2022 conditions

[jan-kaspar]

PR description:

This PR contains three updates:

1. 2022 settings for "direct" simulation of forward protons in PPS, in particular the updated LHC optics estimate from optics for Run3 (prelim.) cms-data/CalibPPS-ESProducers#5
2. For easier maintenance, all optics settings are grouped in one single python config CalibPPS/ESProducers/python/ctppsOpticalFunctions_non_DB_cff.py - also useful for workflows which do not consume conditions from DB.
3. The alignment file Validation/CTPPS/alignment/alignment_2022.xml, wrt. the 2021 version, contains constants adjusted to counteract a shift recently induced by the new Run3 geometry.

PR validation:

The plots below compare results before (blue solid) and after this PR (red dashed):

• for Run2 data reco: reco_cmp.pdf -- no difference as expected
• for direct simulation: dirsim_cmp.pdf -- no difference for 2021 and older, new curves (thus only in red dashed) for 2022 - as expected

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35177/25109

• Error: Found path names starting with digits: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35177/25109/invalid-filenames.txt

• This PR adds an extra 20KB to repository

[tvami]

test parameters:

• pull_request = Update tag for CalibPPS-ESProducers to V01-04-00 cmsdist#7282

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35177/25111

• Error: Found path names starting with digits: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35177/25111/invalid-filenames.txt

• This PR adds an extra 20KB to repository

• Found files with invalid states:

  • Validation/CTPPS/alignment/2022.xml:
    • Added: f4b7e6e
    • Deleted: f58ca81

[smuzaffar]

looks like a bug in filename checking part of bot. I will fix it and re-run the check here soon

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35177/25116

• This PR adds an extra 8KB to repository

• Found files with invalid states:

  • Validation/CTPPS/alignment/2022.xml:
    • Added: f4b7e6e
    • Deleted: f58ca81

[cmsbuild]

A new Pull Request was created by @jan-kaspar for master.

It involves the following packages:

• CalibPPS/ESProducers (alca)
• Validation/CTPPS (dqm)

@malbouis, @andrius-k, @yuanchao, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@fabferro, @mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35177/25118

• This PR adds an extra 8KB to repository

• Found files with invalid states:

  • Validation/CTPPS/alignment/2022.xml:
    • Added: f4b7e6e
    • Deleted: f58ca81

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5d3ea3/18365/summary.html
COMMIT: 41457af
CMSSW: CMSSW_12_1_X_2021-09-07-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35177/18365/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3001001
• DQMHistoTests: Total failures: 11
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3000967
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[tvami]

Hi @jan-kaspar,

1. 2022 settings for "direct" simulation of forward protons in PPS, in particular the updated LHC optics estimate from optics for Run3 (prelim.) cms-data/CalibPPS-ESProducers#5
2. For easier maintenance, all optics settings are grouped in one single python config CalibPPS/ESProducers/python/ctppsOpticalFunctions_non_DB_cff.py - also useful for workflows which do not consume conditions from DB.

do I understand that correctly that they conditions are not expected to change and that's why you choose them to be external root files?

3. The alignment file Validation/CTPPS/alignment/alignment_2022.xml, wrt. the 2021 version, contains constants adjusted to counteract a shift recently induced by the new Run3 geometry.

Kind of the same question: won't the alignment of PPS change over time and so it should not be read from an xml file?

[jan-kaspar]

Hi @tvami ,

the optics and alignment related to this PR reflect the current forecast for Run3 and are intended for preparatory simulations. It is almost clear that in reality both the optics and alignment will be different. These conditions will be deduced from real data and will go to DB for the use in reconstruction. Drawing from the Run2 experience, the optics is expected to be stable (for a year or so) while the alignment may evolve a little fill by fill.

For the (direct) simulation, in Run2, we had to prepare a limited number of profiles (2 or 3 per year) which could reasonably reproduce the data. Given the small number of profiles we kept the optics files in the external repo and the alignment files in CMSSW. If preferable, both can be stored in DB for Run3. In Run2 we rarely (if ever) updated these conditions.

[tvami]

Hi @jan-kaspar thanks for the explanation! If there are ~3 updates per year, I'd say it's already a good motivation to move to the DB. What do you @francescobrivio @malbouis think?

[jan-kaspar]

Hi @jan-kaspar thanks for the explanation! If there are ~3 updates per year, I'd say it's already a good motivation to move to the DB. What do you @francescobrivio @malbouis think?

OK, thanks! I will pass your recommendation to those who will take over from me next year.

[jfernan2]

+dqm

[mrodozov]

you'll need cms-sw/cmsdist#7282 merged before this

[tvami]

+alca

• agreed to move the files to the DB for the future

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1