[HGCAL] Introduce SimTracksters linking #35158

lecriste · 2021-09-05T21:41:11Z

PR description:

This PR:

introduces a vector of indexes between the two SimTracksters collections, and store it into the event;
improve the assignment of the regressed energy to the SimTracksters;
replaces the SimTracksters collection to be used in the corresponding Validation section.

No changes are expected in the output except for the "TSToCP_linking" DQM Validation section.

PR validation:

runTheMatrix -l limited

cmsbuild · 2021-09-05T21:47:12Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35158/25087

This PR adds an extra 24KB to repository

cmsbuild · 2021-09-05T21:47:32Z

A new Pull Request was created by @lecriste (Leonardo Cristella) for master.

It involves the following packages:

RecoHGCal/TICL (upgrade, reconstruction)
Validation/HGCalValidation (dqm)

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @slava77, @jpata, @rvenditti can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @bsunanda, @felicepantaleo, @rovere, @lgray, @cseez, @apsallid, @sobhatta, @pfs, @hatakeyamak, @ebrondol, @clelange this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

AdrianoDee · 2021-09-05T21:53:44Z

please test

cmsbuild · 2021-09-06T01:16:05Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ff9c09/18328/summary.html
COMMIT: 15c89d4
CMSSW: CMSSW_12_1_X_2021-09-05-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35158/18328/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3000491
DQMHistoTests: Total failures: 684
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2999785
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

jfernan2 · 2021-09-06T21:46:23Z

@lecriste are differences like
https://tinyurl.com/yjjearyo
https://tinyurl.com/ygvywqau
expected/understood?

I am confused from your PR description:
"No changes are expected in the output since the Validation section concerned contained already a filter on the input collection objects which screens the replacement in the third bullet above."

lecriste · 2021-09-06T23:57:07Z

@lecriste are differences like
https://tinyurl.com/yjjearyo
https://tinyurl.com/ygvywqau
expected/understood?

@jfernan2 yes, those differences are expected:

lower number of reference truth objects,
worse overall metrics.

In a following PR, we will fill the same Validation plots with the sibling SimTracksters collection and the metrics will improve again.

I am confused from your PR description:
"No changes are expected in the output since the Validation section concerned contained already a filter on the input collection objects which screens the replacement in the third bullet above."

I meant that "No changes are expected in the output except for the Validation section concerned", sorry for not being clear. Shall I clarify the PR description?

jpata

No reco differences observed, good. I agree that the description might be clarified to mention that the Validation particles in DQM are expected to change.
Minor code comments inline.

RecoHGCal/TICL/plugins/SimTrackstersProducer.cc

cmsbuild · 2021-09-07T10:02:07Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35158/25107

This PR adds an extra 16KB to repository

cmsbuild · 2021-09-07T10:02:32Z

Pull request #35158 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @slava77, @jpata, @rvenditti can you please check and sign again.

AdrianoDee · 2021-09-07T10:13:18Z

please test

lecriste · 2021-09-07T10:21:08Z

https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35158/25106/code-checks.patch

@smuzaffar FYI this patch is incorrect.

smuzaffar · 2021-09-07T12:00:08Z

@lecriste I am lookin in to it.

smuzaffar · 2021-09-07T12:32:32Z

looks like a bug in clang-tidy

clang-tidy -export-fixes foo.yaml -header-filter '/build/muz/tidy/CMSSW_12_1_X_2021-09-06-2300/src/.*'  src/RecoHGCal/TICL/plugins/SimTrackstersProducer.cc                                    1337 warnings generated.
RecoHGCal/TICL/plugins/SimTrackstersProducer.cc:169:13: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
        if (result->size() < 1)
            ^~~~~~~~~~~~~~~~~~
            result->->empty()
/cvmfs/cms-ib.cern.ch/nweek-02697/slc7_amd64_gcc900/external/gcc/9.3.0/lib/gcc/x86_64-unknown-linux-gnu/9.3.0/../../../../include/c++/9.3.0/bits/stl_vector.h:1004:7: note: method 'vector'::empty() defined here
      empty() const _GLIBCXX_NOEXCEPT

I will open a bug report with llvm if it not already there

cmsbuild · 2021-09-07T13:23:03Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ff9c09/18357/summary.html
COMMIT: 5979802
CMSSW: CMSSW_12_1_X_2021-09-06-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35158/18357/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 3 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3001001
DQMHistoTests: Total failures: 684
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3000295
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

jfernan2 · 2021-09-07T13:52:45Z

+1

AdrianoDee · 2021-09-07T14:02:54Z

+upgrade

code changes consistent with the PR description
following PR will address the needed changes to restore the metrics in the validation plots (e.g. here)

jpata · 2021-09-07T15:45:26Z

+reconstruction

for 5979802
technical, no relevant reco changes
1325.81 differences look like from Non-reproducibility in DeepTau in 1325.81 #32628, 11634.911 differences look like from Instabilities in 11634.911 (DD4Hep) workflow comparisons #35109

cmsbuild · 2021-09-07T15:45:48Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2021-09-08T18:17:03Z

+1

lecriste added 3 commits September 4, 2021 21:30

Merge SimTracksters producers

c41936f

Improve regressed energy

da38030

Introduce SimTracksters linking

15c89d4

cmsbuild added this to the CMSSW_12_1_X milestone Sep 5, 2021

cmsbuild added code-checks-pending dqm-pending orp-pending pending-signatures reconstruction-pending tests-pending upgrade-pending labels Sep 5, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 5, 2021

cmsbuild added tests-started and removed tests-pending labels Sep 5, 2021

cmsbuild added tests-approved and removed tests-started labels Sep 6, 2021

jpata reviewed Sep 7, 2021

View reviewed changes

RecoHGCal/TICL/plugins/SimTrackstersProducer.cc Outdated Show resolved Hide resolved

RecoHGCal/TICL/plugins/SimTrackstersProducer.cc Outdated Show resolved Hide resolved

RecoHGCal/TICL/plugins/SimTrackstersProducer.cc Outdated Show resolved Hide resolved

lecriste added 2 commits September 7, 2021 10:26

Improve code readability

13c86d8

Reserve vector

0225401

cmsbuild added code-checks-pending tests-pending and removed tests-approved code-checks-approved labels Sep 7, 2021

cmsbuild added the code-checks-pending label Sep 7, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 7, 2021

cmsbuild added tests-started and removed tests-pending labels Sep 7, 2021

cmsbuild added tests-approved and removed tests-started labels Sep 7, 2021

cmsbuild added dqm-approved and removed dqm-pending labels Sep 7, 2021

cmsbuild added upgrade-approved and removed upgrade-pending labels Sep 7, 2021

cmsbuild added fully-signed reconstruction-approved and removed reconstruction-pending pending-signatures labels Sep 7, 2021

cmsbuild added orp-approved and removed orp-pending labels Sep 8, 2021

cmsbuild merged commit cab6180 into cms-sw:master Sep 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HGCAL] Introduce SimTracksters linking #35158

[HGCAL] Introduce SimTracksters linking #35158

lecriste commented Sep 5, 2021 •

edited

Loading

cmsbuild commented Sep 5, 2021

cmsbuild commented Sep 5, 2021

AdrianoDee commented Sep 5, 2021

cmsbuild commented Sep 6, 2021

jfernan2 commented Sep 6, 2021

lecriste commented Sep 6, 2021

jpata left a comment

cmsbuild commented Sep 7, 2021

cmsbuild commented Sep 7, 2021

AdrianoDee commented Sep 7, 2021

lecriste commented Sep 7, 2021

smuzaffar commented Sep 7, 2021 •

edited

Loading

smuzaffar commented Sep 7, 2021

cmsbuild commented Sep 7, 2021

jfernan2 commented Sep 7, 2021

AdrianoDee commented Sep 7, 2021

jpata commented Sep 7, 2021

cmsbuild commented Sep 7, 2021

perrotta commented Sep 8, 2021

[HGCAL] Introduce SimTracksters linking #35158

[HGCAL] Introduce SimTracksters linking #35158

Conversation

lecriste commented Sep 5, 2021 • edited Loading

PR description:

PR validation:

cmsbuild commented Sep 5, 2021

cmsbuild commented Sep 5, 2021

AdrianoDee commented Sep 5, 2021

cmsbuild commented Sep 6, 2021

Comparison Summary

jfernan2 commented Sep 6, 2021

lecriste commented Sep 6, 2021

jpata left a comment

Choose a reason for hiding this comment

cmsbuild commented Sep 7, 2021

cmsbuild commented Sep 7, 2021

AdrianoDee commented Sep 7, 2021

lecriste commented Sep 7, 2021

smuzaffar commented Sep 7, 2021 • edited Loading

smuzaffar commented Sep 7, 2021

cmsbuild commented Sep 7, 2021

Comparison Summary

jfernan2 commented Sep 7, 2021

AdrianoDee commented Sep 7, 2021

jpata commented Sep 7, 2021

cmsbuild commented Sep 7, 2021

perrotta commented Sep 8, 2021

lecriste commented Sep 5, 2021 •

edited

Loading

smuzaffar commented Sep 7, 2021 •

edited

Loading