Remove unused headers in several package.

[yuanchao]

PR description:

Remove unused header for DataFormats packages #5

Following the issue #31505, the following headers are unused in several package:

• EventFilter/DTRawToDigi/interface/DTROS25Data.h
• EventFilter/ESRawToDigi/interface/ESCrcKchipFast.h
• EventFilter/EcalRawToDigi/interface/ECALUnpackerException.h
• EventFilter/EcalRawToDigi/interface/MyWatcher.h
• EventFilter/RPCRawToDigi/interface/RPCRawSynchro.h
• EventFilter/Utilities/interface/ModuleWeb.h
• EventFilter/Utilities/interface/config_json.h
• FWCore/ServiceRegistry/interface/TypeInfoHolder.h
• GeneratorInterface/TauolaInterface/interface/TauolaWrapper.h
• HeavyFlavorAnalysis/SpecificDecay/interface/BPHMuonChargeSelect.h
• HeavyFlavorAnalysis/SpecificDecay/interface/BPHParticleChargeSelect.h
• IOPool/Common/interface/CustomStreamer.h
• JetMETCorrections/InterpolationTables/interface/BoxNDScanner.h
• JetMETCorrections/InterpolationTables/interface/MultivariateFunctorScanner.h
• JetMETCorrections/InterpolationTables/interface/rescanArray.h
• JetMETCorrections/Type1MET/interface/CorrectedMETProducerT.h
• L1Trigger/DTSectorCollector/interface/DTSCCand.h
• L1Trigger/GlobalCaloTrigger/interface/L1GctSimpleJetFinder.h
• L1Trigger/L1TCalorimeter/interface/classes.h
• L1Trigger/L1TMuonOverlap/interface/OMTFConfigurator.h
• L1Trigger/L1TMuonOverlap/interface/OMTFPatternMaker.h
• L1Trigger/L1TNtuples/interface/L1AnalysisRecoTrackBase.h
• L1TriggerOffline/L1Analyzer/interface/L1PromptAnalysis.h
• MagneticField/Engine/interface/MagneticFieldHelpers.h
• MagneticField/VolumeGeometry/interface/RectangularVolumeBounds.h
• Mixing/Base/interface/FixedPUGenerator.h
• Mixing/Base/interface/PUGenerator.h

PR validation:

Code compiles. Run local limited runTheMatrix.py tests.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport and no backport forseen.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35105/24994

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @yuanchao (Yuan CHAO) for master.

It involves the following packages:

• EventFilter/DTRawToDigi (reconstruction)
• EventFilter/ESRawToDigi (reconstruction)
• EventFilter/EcalRawToDigi (reconstruction)
• EventFilter/RPCRawToDigi (reconstruction)
• EventFilter/Utilities (daq, reconstruction)
• FWCore/ServiceRegistry (core)
• GeneratorInterface/TauolaInterface (generators)
• HeavyFlavorAnalysis/SpecificDecay (analysis)
• IOPool/Common (core)
• JetMETCorrections/InterpolationTables (analysis)
• JetMETCorrections/Type1MET (reconstruction)
• L1Trigger/DTSectorCollector (l1)
• L1Trigger/GlobalCaloTrigger (l1)
• L1Trigger/L1TCalorimeter (l1)
• L1Trigger/L1TMuonOverlap (l1)
• L1Trigger/L1TNtuples (l1)
• L1TriggerOffline/L1Analyzer (l1)
• MagneticField/Engine (reconstruction)
• MagneticField/VolumeGeometry (reconstruction)
• Mixing/Base (simulation)

@SiewYan, @smuzaffar, @civanch, @Dr15Jones, @jpata, @mkirsano, @makortel, @emeschi, @Saptaparna, @smorovic, @cmsbuild, @rekovic, @agrohsje, @mdhildreth, @slava77, @alberto-sanchez, @santocch, @cecilecaillol, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @argiro, @Martin-Grunewald, @thomreis, @alberto-sanchez, @seemasharmafnal, @mmarionncern, @kreczko, @battibass, @makortel, @jdolen, @fwyzard, @simonepigazzini, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @fabiocos, @clelange, @namapane, @mkirsano, @rchatter, @wddgit, @ahinzmann, @dinyar, @mariadalfonso this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[yuanchao]

@cmsbuild please test

[smorovic]

+1
ok to remove unused headers in EventFilter/Utilities

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf50f2/18204/summary.html
COMMIT: b09e121
CMSSW: CMSSW_12_1_X_2021-08-31-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35105/18204/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000404
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000376
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[makortel]

+core

[civanch]

+1

[santocch]

+1

[camclean]

The first three JME header files should be fine to remove. We're checking on the fourth.

[michaelwassmer]

I had a look at the CorrectedMETProducer and I'd hesitate to remove it. It is the generic template of e.g.
JetMETCorrections/Type1MET/plugins/CorrectedPFMETProducer.cc
and if you search for this producer alone one finds some instances in HLTTrigger, see
https://cmssdt.cern.ch/lxr/search?%21v=CMSSW_12_1_X_2021-09-13-2300&_filestring=&_string=CorrectedPFMETProducer
I'm not sure if these are important or not. Also the CorrectedPFMETProducer is imported e.g. by
JetMETCorrections/Type1MET/python/correctedMet_cff.py
which is imported on other instances, see
https://cmssdt.cern.ch/lxr/search?%21v=CMSSW_12_1_X_2021-09-13-2300&_filestring=&_string=correctedMET_cff
I think the probability that the correction sequences for MET are used in some production sequences/steps are not that low.
In summary, I guess I would keep that for now, maybe @lathomas can comment on this with more expertise.
EDIT: Now looking at it again, it seems that the CorrectedPFMETProducer and CorrectedCaloMETProducer actually do not seem to be instances of the template but their own contrary to the description in the comments. Maybe this was the case at some time earlier.

[jpata]

Thanks JME folks for the follow-up. So it looks like all these headers can be removed indeed.

[jpata]

+reconstruction

• for b09e121
• technical, removes unused headers
• in the reco area, we explicitly checked the headers of the various areas for nonstandard/out-of-workflows use: Remove unused headers in several package. #35105 (comment)
• no reco differences expected/observed

[qliphy]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf50f2/18733/summary.html
COMMIT: b09e121
CMSSW: CMSSW_12_1_X_2021-09-18-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35105/18733/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3211080
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211058
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[qliphy]

+1

[qliphy]

please test

Several files are adding back: jrotter2@ceb3535

@cms-sw/l1-l2 Please have a look.

[jpata]

I'm confused about the latest update in ceb3535. Was e.g. CorrectedMETProducerT.h now added back? Can you please check that the description is up to date?

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf50f2/18812/summary.html
COMMIT: b09e121
CMSSW: CMSSW_12_1_X_2021-09-21-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35105/18812/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3211080
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211058
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[qliphy]

I'm confused about the latest update in ceb3535. Was e.g. CorrectedMETProducerT.h now added back? Can you please check that the description is up to date?

@yuanchao FYI

[jpata]

OK, as far as I can tell, nothing was added back. It's simply that a commit in a private fork of CMSSW referenced this issue, which caused it to show up here (a retest was consequently not really necessary I think).

Looking at the commit history of this PR (https://github.com/cms-sw/cmssw/pull/35105/commits), there is just one commit, the removal of all the files listed. So no complaints from reco.

[qliphy]

merge