-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have embedded root files send close reports #35074
Conversation
When a file controlled by the RootEmbeddedFileSequence closes, it now informs the StatisticsSenderService.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35074/24957
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages:
@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c8c5f/18141/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
When a file controlled by the RootEmbeddedFileSequence closes, it now informs the StatisticsSenderService.
Had to call the service directly as there was no good way to pass the ActivityRegistry into a class meant to be embedded inside a ED module.
PR validation:
Code compiles and framework unit tests pass. I had no way to check to see if the messages are actually being sent.
fixes #34873