PPS: solving issue 35033 for CTPPSPixelRecHits

[fabferro]

PR description:

This PR should solve issue #35033 for CTPPSPixelRecHits. It explicitily initialize LocalPoint and LocalError members of CTPPSPixelRecHit.

PR validation:

Running 136.885 wf with IB CMSSW_12_1_UBSAN_X_2021-08-20-2300 the error does not show up.
No changes seen in private reprocessing of Run2 data samples.

@jan-kaspar

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35053/24927

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @fabferro (Fabrizio Ferro) for master.

It involves the following packages:

• DataFormats/CTPPSReco (reconstruction)

@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@jan-kaspar, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6365b7/18108/summary.html
COMMIT: 88c0620
CMSSW: CMSSW_12_1_X_2021-08-27-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35053/18108/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000352
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000324
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #35053 88c0620

• code changes are in line with the PR description and the preceding discussion in [UBSAN] Undefined behavior in DataFormats/* reco packages #35033; the CTPPSPixelRecHit default constructor now sets values to data members.
• jenkins tests pass and comparisons with the baseline show no differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1