Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fixed destruction of Geant4 simulation" #35047

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

qliphy
Copy link
Contributor

@qliphy qliphy commented Aug 27, 2021

Reverts #35002 as this seems to cause IB failures, see discussed in #35002

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @qliphy (Qiang Li) for CMSSW_10_6_X.

It involves the following packages:

  • SimG4Core/Application (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @cvuosalo, @rovere, @bsunanda, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@qliphy
Copy link
Contributor Author

qliphy commented Aug 27, 2021

@civanch @perrotta Please proceed if you are fine with this revert.

@qliphy
Copy link
Contributor Author

qliphy commented Aug 27, 2021

enable threading

@qliphy
Copy link
Contributor Author

qliphy commented Aug 27, 2021

please test

@civanch
Copy link
Contributor

civanch commented Aug 27, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Aug 27, 2021

  • Let see if this can help fixing the failures in the 10_6 IB

@perrotta
Copy link
Contributor

(Let the tests finish first...)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4024d9/18095/summary.html
COMMIT: 6dc3219
CMSSW: CMSSW_10_6_X_2021-08-26-2300/slc7_amd64_gcc700
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35047/18095/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215351
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 143 log files, 29 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit dd434aa into CMSSW_10_6_X Aug 27, 2021
@smuzaffar smuzaffar deleted the revert-35002-fixed_destruction branch April 25, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants