Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_0_X]Fix on compilation issues with DMR, GC and MTS validation scripts. #35025

Merged

Conversation

TomasKello
Copy link
Contributor

PR description:

Introduces several fixes on tracker alignment validation scripts and macros which appeared to throw errors during compilation. Errors are mostly due to type conversion issues (TString <-> std::string) and broken forward declaration of imported classes and a few typos.
No changes in output are expected.

PR validation:

Changed macros were successfully tested during Alignment Validation on data and MC.

Backport of #35016

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 26, 2021

A new Pull Request was created by @TomasKello for CMSSW_12_0_X.

It involves the following packages:

  • Alignment/OfflineValidation (alca)

@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Aug 26, 2021

type bug-fix

@mmusich
Copy link
Contributor

mmusich commented Aug 26, 2021

backport of #35016

@mmusich
Copy link
Contributor

mmusich commented Aug 26, 2021

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e5bd3/18049/summary.html
COMMIT: 5396089
CMSSW: CMSSW_12_0_X_2021-08-25-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35025/18049/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998542
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Aug 26, 2021

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Aug 29, 2021

+1

@cmsbuild cmsbuild merged commit a6516bc into cms-sw:CMSSW_12_0_X Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants