-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12_0_X]Fix on compilation issues with DMR, GC and MTS validation scripts. #35025
[12_0_X]Fix on compilation issues with DMR, GC and MTS validation scripts. #35025
Conversation
A new Pull Request was created by @TomasKello for CMSSW_12_0_X. It involves the following packages:
@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
type bug-fix |
backport of #35016 |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e5bd3/18049/summary.html Comparison SummarySummary:
|
+alca |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Introduces several fixes on tracker alignment validation scripts and macros which appeared to throw errors during compilation. Errors are mostly due to type conversion issues (TString <-> std::string) and broken forward declaration of imported classes and a few typos.
No changes in output are expected.
PR validation:
Changed macros were successfully tested during Alignment Validation on data and MC.
Backport of #35016