-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Condtools-DT modules to esConsumes #35023
Conversation
I have updated the google doc |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35023/24882
|
A new Pull Request was created by @sroychow (Suvankar Roy Chowdhury) for master. It involves the following packages:
@ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d7e71/18042/summary.html CMS StaticAnalyzer warnings: There are 1 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d7e71/18042/llvm-analysis/legacy-mod-sa.txt for details. Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
ping @sroychow |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35023/25216
|
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d7e71/18534/summary.html Comparison SummarySummary:
|
+db
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Part of #31061. Migrate plugins of
CondTools/DT/
to use esConsumes. Apart from that, cout statements were removed. Standalone analyzers inside the test directory have been migrated to use esConsumes as well.PR validation:
Code compiles and scram checks don't show the
EventSetupRecord::get
warning.#Backport
NA