-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation plots for APE and bug fixes: Backport of #34828 #35007
Validation plots for APE and bug fixes: Backport of #34828 #35007
Conversation
A new Pull Request was created by @mteroerd (Marius Teroerde) for CMSSW_12_0_X. It involves the following packages:
@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
type bug-fix |
@cmsbuild please test |
backport of #34828 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-36b0e0/18018/summary.html Comparison SummarySummary:
|
+alca |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Changes to the APE tool:
-Bug fixes: Remove lines that were previously added to prevent memory leaks, but which created errors. Also tweak some lines in test/plottingTools.
-Added a new plotting tool to allow for creation of plots with residual distributions plus some other validation plots.
-Added an option to autoSubmitter, so that APE can be more easily measured on cosmics data sets.
PR validation:
Ran some basic tests of the code on the most recent APE campaign to confirm that the changes work as intended.
if this PR is a backport please specify the original PR and why you need to backport that PR:
Backport of #34828