TkDQM: Fix tracker maps for run3

[sroychow]

PR description:

This PR is aimed at resolving #34607 . The reading capability of a TDirectory based ROOT file is enabled in the LegacyIOHelper and that is used by the SiStripOfflineDQM module. In addition, this PR adds a unit test for the offline TkMap creation.
Thanks to @mmusich for debugging several aspects of the changes. Some bug fixes for some of the TkMaps are expected which can come as a separate PR later.

PR validation:

The updates have been tested privately and Tracker Maps are getting produced with DQM harvested root file as an input.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport will be done for 11_3 and 12_0.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34966/24802

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQM/SiStripMonitorClient/test/BuildFile.xml modified in PR(s): add unit test for SiStripDQM_OfflineTkMap #34920
  • File DQM/SiStripMonitorClient/test/test_SiStripDQM_OfflineTkMap.sh modified in PR(s): add unit test for SiStripDQM_OfflineTkMap #34920

[cmsbuild]

A new Pull Request was created by @sroychow (Suvankar Roy Chowdhury) for master.

It involves the following packages:

• DQM/SiStripMonitorClient (dqm)
• DQMServices/Core (dqm)

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@arossi83, @barvic, @hdelanno, @sroychow, @fioriNTU, @jandrea, @idebruyn, @threus, @venturia this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[sroychow]

@cmsbuild please test

[mmusich]

type bug-fix

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34966/24806

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQM/SiStripMonitorClient/test/BuildFile.xml modified in PR(s): add unit test for SiStripDQM_OfflineTkMap #34920
  • File DQM/SiStripMonitorClient/test/test_SiStripDQM_OfflineTkMap.sh modified in PR(s): add unit test for SiStripDQM_OfflineTkMap #34920

[cmsbuild]

Pull request #34966 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34966/24917

• This PR adds an extra 32KB to repository

[mmusich]

@cmsbuild, please test

[mmusich]

urgent

[cmsbuild]

Pull request #34966 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @jfernan2, @rvenditti can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf236d/18092/summary.html
COMMIT: 0f15cfc
CMSSW: CMSSW_12_1_X_2021-08-27-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34966/18092/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000352
• DQMHistoTests: Total failures: 11
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3000318
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1