[12.0.X] migrate AlignmentProducer to event consumes

[mmusich]

backport of #34885

PR description:

Title says it all, migrate AlignmentProducer to event consumes, as it is already done for AlignmentProducerAsAnalyzer.cc

cmssw/Alignment/CommonAlignmentProducer/plugins/AlignmentProducerAsAnalyzer.cc

Lines 21 to 25 in bd636b9

	tjTkAssociationMapToken_ = consumes<TrajTrackAssociationCollection>(tjTkAssociationMapTag_);
	beamSpotToken_ = consumes<reco::BeamSpot>(beamSpotTag_);
	tkLasBeamToken_ = consumes<TkFittedLasBeamCollection>(tkLasBeamTag_);
	tsosVectorToken_ = consumes<TsosVectorCollection>(tkLasBeamTag_);
	clusterValueMapToken_ = consumes<AliClusterValueMap>(clusterValueMapTag_);

PR validation:

Run unit tests scram b runtests also using Alignment/TrackerAlignment package.

if this PR is a backport please specify the original PR and why you need to backport that PR:

12.0.X backport of PR #34885

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_0_X.

It involves the following packages:

• Alignment/CommonAlignmentProducer (alca)

@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@pakhotin, @mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from migrate AlignmentProducer to event consumes #34885

[mmusich]

type bug-fix

[perrotta]

type bug-fix

Why "bug fix"? Migration to event consumes is not mandatory for 12_0_X.
Does this PR fix some other bug in the meanwhile?

[mmusich]

Migration to event consumes is not mandatory for 12_0_X.

This doesn't match my observations.
Without this it leads to:

----- Begin Fatal Exception 13-Aug-2021 21:45:33 CEST-----------------------
An exception of category 'GetByLabelWithoutRegistration' occurred while
   [0] Calling the 'duringLoop' method of a looper
Exception Message:
::getByLabel without corresponding call to consumes or mayConsumes for this module.
  type: reco::BeamSpot
  module label: offlineBeamSpot
  product instance name: ''
  process name: ''
----- End Fatal Exception -------------------------------------------------

same holds true for 11.3.X

[perrotta]

@mmusich ok, you are right. The issue solved here is that the code missed the consumes call at all.
I got confused with the currently ongoing migration to esConsumes()...

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-82f9ff/17882/summary.html
COMMIT: 4462af2
CMSSW: CMSSW_12_0_X_2021-08-18-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34947/17882/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2998535
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1