Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix radix sort test (12.0.x) #34930

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Aug 18, 2021

PR description:

Fix the compilation errors in HeterogeneousCore/CUDAUtilities/test/radixSort_t.cu:

  • take into account the actual size of the type being sorted, instead of always assuming a 64-bit type;
  • use an union instead of a cast to keep the compiler happy about the aliasing rules.

PR validation:

gpuRadixSort_t compiles and runs fine.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #34929.

Take into account the actual size of the type being sorted.

Use an union instead of a cast to keep the compiler happy about the
aliasing rules.
@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 18, 2021

type bugfix

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 18, 2021

backport #34929

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 18, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 18, 2021

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_12_0_X.

It involves the following packages:

  • HeterogeneousCore/CUDAUtilities (heterogeneous)

@makortel, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 18, 2021

+heterogeneous

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0cfe6b/17850/summary.html
COMMIT: bd35faa
CMSSW: CMSSW_12_0_X_2021-08-17-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34930/17850/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998529
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@qliphy
Copy link
Contributor

qliphy commented Aug 19, 2021

+1

@cmsbuild cmsbuild merged commit 261229f into cms-sw:CMSSW_12_0_X Aug 19, 2021
@fwyzard fwyzard deleted the fix_radix_sort_test_120x branch August 19, 2021 07:42
@fwyzard fwyzard restored the fix_radix_sort_test_120x branch August 19, 2021 07:42
@fwyzard fwyzard deleted the fix_radix_sort_test_120x branch August 19, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants