Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alignment/HIPAlignmentAlgorithm] modernize LhcTrackAnalyzer #34881

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 14, 2021

PR description:

Title says it all.

PR validation:

Privately run Alignment/HIPAlignmentAlgorithm/test/LHCAnalyzer_cfg.py

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild cmsbuild added this to the CMSSW_12_1_X milestone Aug 14, 2021
@mmusich mmusich force-pushed the modernizeLhcTrackAnalyzer branch from bcb8c22 to 8f99636 Compare August 14, 2021 16:51
@mmusich mmusich changed the title [Alignment/HIPAlignmentAlgorthm] modernize LhcTrackAnalyzer [Alignment/HIPAlignmentAlgorithm] modernize LhcTrackAnalyzer Aug 14, 2021
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34881/24683

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Alignment/HIPAlignmentAlgorithm (alca)

@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @adewit this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Aug 14, 2021

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d569ba/17780/summary.html
COMMIT: 8f99636
CMSSW: CMSSW_12_1_X_2021-08-14-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34881/17780/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2999420
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2999397
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34881/24686

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

Pull request #34881 was updated. @malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio, @tvami can you please check and sign again.

@tvami
Copy link
Contributor

tvami commented Aug 15, 2021

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34881/24687

  • This PR adds an extra 32KB to repository

@mmusich
Copy link
Contributor Author

mmusich commented Aug 15, 2021

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

Pull request #34881 was updated. @malbouis, @yuanchao, @tlampen, @pohsun, @francescobrivio, @tvami can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d569ba/17783/summary.html
COMMIT: e387347
CMSSW: CMSSW_12_1_X_2021-08-15-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34881/17783/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2999420
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2999397
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Aug 15, 2021

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Aug 16, 2021

+1

@cmsbuild cmsbuild merged commit 28dbc9f into cms-sw:master Aug 16, 2021
@mmusich mmusich deleted the modernizeLhcTrackAnalyzer branch August 16, 2021 07:03
@iarspider
Copy link
Contributor

@mmusich it seems that this update broke IBs: gcc10, clang. Also QA now complains about duplicate dictionaries: link

@mmusich
Copy link
Contributor Author

mmusich commented Aug 17, 2021

@iarspider see #34903

@iarspider
Copy link
Contributor

Ah. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants