[MagneticField] Move public headers to interface directory

[smuzaffar]

As reported in #34718 , this PR moves headers in interface directory for MagneticField

      2 src/MagneticField/Layers/src/MagBinFinders.h

cleanup unnecessary include of

      1 src/MagneticField/ParametrizedEngine/src/OAEParametrizedMagneticField.h

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34763/24428

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• Configuration/Skimming (pdmv)
• MagneticField/Layers (reconstruction)
• MagneticField/VolumeBasedEngine (reconstruction)

@perrotta, @jordan-martins, @chayanit, @bbilin, @wajidalikhan, @cmsbuild, @kskovpen, @slava77, @jpata can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @namapane, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

@namapane , sorry the PR description was wrong . I have updated it, yes MagneticField/ParametrizedEngine/src/OAEParametrizedMagneticField.h remains in the src directory. There was an unnecessary include of it which I have cleaned up. The MagneticField/Layers/src/MagBinFinders.h is actually used by other package so that should go in to interface directory.

[namapane]

Perfect, thanks @smuzaffar for the clarification!

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c6c68/17532/summary.html
COMMIT: c287453
CMSSW: CMSSW_12_1_X_2021-08-03-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34763/17532/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2998535
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #34763 c287453

• code changes are technical, in line with the PR description
• jenkins tests pass and comparisons with the baseline show no (relevant) differences

[bbilin]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1