Run3-alca189 Add a few Hcal related AlCaReco streams (HcalCalIterativePhiSym, HcalCalHBHEMuonFilter, HcalCalHO, HcalCalIsoTrkFilter) to the physics data stream HLTPhysics #34628

bsunanda · 2021-07-26T16:33:14Z

PR description:

Add a few Hcal related AlCaReco streams (HcalCalIterativePhiSym, HcalCalHBHEMuonFilter, HcalCalHO, HcalCalIsoTrkFilter) to the physics data stream HLTPhysics

PR validation:

Tested with some old datasets and results presented in the AlCaReco meeting: https://indico.cern.ch/event/1060075/contributions/4454870/attachments/2287447/3888027/IsoTrigger08.pdf

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport of this PR is foreseen

cmsbuild · 2021-07-26T16:42:32Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34628/24214

This PR adds an extra 20KB to repository

cmsbuild · 2021-07-26T16:42:57Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Calibration/HcalAlCaRecoProducers (alca)
Calibration/HcalCalibAlgos (alca)
Configuration/AlCa (alca)

@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2021-07-26T16:46:59Z

@cmsbuild Please test

tvami

Just some cosmetic changes

tvami · 2021-07-26T17:03:52Z

Calibration/HcalCalibAlgos/test/python/isoTrackRecoAnalysis_cfg.py

-#106X_mcRun3_2021_realistic_v3
+from Configuration.AlCa.GlobalTag import GlobalTag
+process.GlobalTag = GlobalTag(process.GlobalTag,'auto:run2_data','')
+#auto:run3_mc


Please remove commented out line

tvami · 2021-07-26T17:04:33Z

Calibration/HcalCalibAlgos/test/python/isoTrackRecoAnalysis_cfg.py

+        #'/store/mc/Run3Summer19DR/DoublePion_E-50/GEN-SIM-RECO/2021ScenarioNZSRECONoPU_106X_mcRun3_2021_realistic_v3-v2/270000/22481A14-0F65-E046-809A-C03709C76325.root'                        
+        #'root://xrootd.ba.infn.it///store/data/Run2017E/JetHT/ALCARECO/HcalCalIsoTrkFilter-09Aug2019_UL2017-v1/50000/FF19B3B8-39D3-D941-8162-1AA7FB482D48.root'


If you are already touching this file for cosmetic purposes, would you mind removing these lines too? Or explain why they might be needed?

tvami · 2021-07-26T17:08:19Z

Hi @bsunanda , may I ask what the "Run3-alca189" refers to in the title of the PR? Also for the validation part, do you maybe have a presentation to refer to? I assume "Nothing special" means there is no need for a backport. Thanks!

bsunanda · 2021-07-26T17:21:34Z

@cmsbuild Please test

cmsbuild · 2021-07-26T17:26:01Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34628/24215

This PR adds an extra 20KB to repository

cmsbuild · 2021-07-26T17:26:26Z

Pull request #34628 was updated. @malbouis, @yuanchao, @tlampen, @pohsun, @francescobrivio, @tvami can you please check and sign again.

cmsbuild · 2021-07-26T22:11:20Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b0c50/17212/summary.html
COMMIT: 1715b64
CMSSW: CMSSW_12_0_X_2021-07-26-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34628/17212/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

11634.011634.0_TTbar_14TeV+2021+TTbar_14TeV_TuneCP5_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_TTbar_14TeV+2021+TTbar_14TeV_TuneCP5_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
11601.011601.0_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
11602.011602.0_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log

Expand to see more relval errors ...

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 1 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2998564
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2998541
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: found differences in 1 / 38 workflows

bsunanda · 2021-07-26T22:30:39Z

@cmsbuild Please test

cmsbuild · 2021-07-27T04:43:31Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8b0c50/17222/summary.html
COMMIT: 1715b64
CMSSW: CMSSW_12_0_X_2021-07-26-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34628/17222/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2998564
DQMHistoTests: Total failures: 12
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2998529
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: found differences in 1 / 38 workflows

srimanob · 2021-07-27T15:19:43Z

Urgent

tvami · 2021-07-27T15:24:12Z

Hi @bsunanda , may I ask what the "Run3-alca189" refers to in the title of the PR? Also for the validation part, do you maybe have a presentation to refer to? I assume "Nothing special" means there is no need for a backport. Thanks!

Hi @bsunanda I can sign this after you do these changes, thanks!

bsunanda · 2021-07-27T16:28:42Z

@tvami Made the required changes

tvami · 2021-07-27T16:33:19Z

+alca

cmsbuild · 2021-07-27T16:33:39Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

bsunanda · 2021-07-27T16:35:48Z

It also changes behavior of the filters.

…

________________________________ From: Marco Musich ***@***.*** Sent: 27 July 2021 17:35 To: cms-sw/cmssw Cc: Sunanda Banerjee; Mention Subject: Re: [cms-sw/cmssw] Run3-alca189 Add a few Hcal related AlCaReco streams to HLTPhysics (#34628) Urgent out of curiosity, why is this urgent? The real AlCaMatrix is driven by Tier-0 configuration, this just updates tests. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#34628 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOTZI5PDG3LMATOKM23TZ3G5PANCNFSM5BAOUXRA>.

qliphy · 2021-07-27T16:49:29Z

+1

Add a few Hcal related AlCaReco streams to HLTPhysics

485f8df

cmsbuild added this to the CMSSW_12_0_X milestone Jul 26, 2021

cmsbuild added alca-pending code-checks-pending orp-pending pending-signatures tests-pending labels Jul 26, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 26, 2021

cmsbuild added tests-started and removed tests-pending labels Jul 26, 2021

tvami suggested changes Jul 26, 2021

View reviewed changes

Remove the commented lines

1715b64

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-started labels Jul 26, 2021

cmsbuild added tests-started and removed tests-pending labels Jul 26, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 26, 2021

cmsbuild removed the tests-started label Jul 26, 2021

cmsbuild added the tests-rejected label Jul 26, 2021

cmsbuild added tests-started and removed tests-rejected labels Jul 26, 2021

cmsbuild added tests-approved and removed tests-started labels Jul 27, 2021

cmsbuild added the urgent label Jul 27, 2021

bsunanda changed the title ~~Run3-alca189 Add a few Hcal related AlCaReco streams to HLTPhysics~~ Run3-alca189 Add a few Hcal related AlCaReco streams (HcalCalIterativePhiSym, HcalCalHBHEMuonFilter, HcalCalHO, HcalCalIsoTrkFilter) to the physics data stream HLTPhysics Jul 27, 2021

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Jul 27, 2021

cmsbuild added orp-approved and removed orp-pending labels Jul 27, 2021

cmsbuild merged commit bc6f603 into cms-sw:master Jul 27, 2021

This was referenced Jul 27, 2021

Enable printout in ReusableObjectHolder test #34651

Merged

Fix crash on edit of Jet collection after view destruction #34655

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run3-alca189 Add a few Hcal related AlCaReco streams (HcalCalIterativePhiSym, HcalCalHBHEMuonFilter, HcalCalHO, HcalCalIsoTrkFilter) to the physics data stream HLTPhysics #34628

Run3-alca189 Add a few Hcal related AlCaReco streams (HcalCalIterativePhiSym, HcalCalHBHEMuonFilter, HcalCalHO, HcalCalIsoTrkFilter) to the physics data stream HLTPhysics #34628

bsunanda commented Jul 26, 2021 •

edited

Loading

cmsbuild commented Jul 26, 2021

cmsbuild commented Jul 26, 2021

bsunanda commented Jul 26, 2021

tvami left a comment

tvami Jul 26, 2021

tvami Jul 26, 2021

tvami commented Jul 26, 2021

bsunanda commented Jul 26, 2021

cmsbuild commented Jul 26, 2021

cmsbuild commented Jul 26, 2021

cmsbuild commented Jul 26, 2021

bsunanda commented Jul 26, 2021

cmsbuild commented Jul 27, 2021

srimanob commented Jul 27, 2021

tvami commented Jul 27, 2021

bsunanda commented Jul 27, 2021

tvami commented Jul 27, 2021

cmsbuild commented Jul 27, 2021

bsunanda commented Jul 27, 2021 via email

qliphy commented Jul 27, 2021

		#'/store/mc/Run3Summer19DR/DoublePion_E-50/GEN-SIM-RECO/2021ScenarioNZSRECONoPU_106X_mcRun3_2021_realistic_v3-v2/270000/22481A14-0F65-E046-809A-C03709C76325.root'
		#'root://xrootd.ba.infn.it///store/data/Run2017E/JetHT/ALCARECO/HcalCalIsoTrkFilter-09Aug2019_UL2017-v1/50000/FF19B3B8-39D3-D941-8162-1AA7FB482D48.root'

Run3-alca189 Add a few Hcal related AlCaReco streams (HcalCalIterativePhiSym, HcalCalHBHEMuonFilter, HcalCalHO, HcalCalIsoTrkFilter) to the physics data stream HLTPhysics #34628

Run3-alca189 Add a few Hcal related AlCaReco streams (HcalCalIterativePhiSym, HcalCalHBHEMuonFilter, HcalCalHO, HcalCalIsoTrkFilter) to the physics data stream HLTPhysics #34628

Conversation

bsunanda commented Jul 26, 2021 • edited Loading

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jul 26, 2021

cmsbuild commented Jul 26, 2021

bsunanda commented Jul 26, 2021

tvami left a comment

Choose a reason for hiding this comment

tvami Jul 26, 2021

Choose a reason for hiding this comment

tvami Jul 26, 2021

Choose a reason for hiding this comment

tvami commented Jul 26, 2021

bsunanda commented Jul 26, 2021

cmsbuild commented Jul 26, 2021

cmsbuild commented Jul 26, 2021

cmsbuild commented Jul 26, 2021

RelVals-INPUT

Comparison Summary

bsunanda commented Jul 26, 2021

cmsbuild commented Jul 27, 2021

Comparison Summary

srimanob commented Jul 27, 2021

tvami commented Jul 27, 2021

bsunanda commented Jul 27, 2021

tvami commented Jul 27, 2021

cmsbuild commented Jul 27, 2021

bsunanda commented Jul 27, 2021 via email

qliphy commented Jul 27, 2021

bsunanda commented Jul 26, 2021 •

edited

Loading