MTD geometry: fix scenario I14 for material budget studies

[fabiocos]

PR description:

This is a minimal completion of the input provided to @bsunanda for #34481 to allow MTD material budget studies with scenario I14.

PR validation:

Code runs and provides material budget plots, as presented by @martatornago in https://indico.cern.ch/event/1057473/contributions/4444289/attachments/2279146/3872237/ETLGeometryUpdate.pdf

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34625/24211

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

• Geometry/MTDCommonData (geometry, upgrade)
• Validation/Geometry (geometry, dqm)

@civanch, @Dr15Jones, @ahmad3213, @kmaeshima, @cvuosalo, @andrius-k, @kpedro88, @ianna, @cmsbuild, @makortel, @srimanob, @jfernan2, @mdhildreth, @ErnestaP, @rvenditti can you please review it and eventually sign? Thanks.
@vargasa, @rovere, @apsallid, @bsunanda, @lecriste, @ebrondol, @rishabhCMS, @rbartek this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

-1

Failed Tests: UnitTests RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f3dc7c/17207/summary.html
COMMIT: 74bec7e
CMSSW: CMSSW_12_0_X_2021-07-26-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34625/17207/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test materialBudgetTrackerPlots had ERRORS
---> test materialBudgetHGCalPlots had ERRORS

RelVals-INPUT

• 11602.011602.0_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
• 11601.011601.0_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
• 11603.011603.0_SingleElectronPt1000+2021+SingleElectronPt1000_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt1000+2021+SingleElectronPt1000_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log

Expand to see more relval errors ...

• 11604.0
• 11605.0
• 11606.0
• 11607.0
• 11608.0
• 11609.0
• 11630.0
• 11634.0
• 11634.1
• 11634.24
• 11634.5
• 11634.501
• 11634.505
• 11634.511
• 11634.521
• 11634.7
• 11634.91
• 11640.0
• 11643.0
• 11646.0
• 11650.0
• 11650.501
• 11650.505
• 11723.17
• 11725.0
• 11834.0
• 11834.13
• 11834.24
• 11846.0
• 12034.0
• 12834.0
• 23434.9921
• 11925.0
• 12434.0
• 12634.0
• 13034.0
• 23434.99
• 23434.21
• 34834.9921
• 34834.21

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2998541
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[fabiocos]

I do not see how the listed errors might have anything to do with this PR, the failing unit tests are the same failing in the IB, and should not be affected by these changes

[jfernan2]

+1

[srimanob]

+Upgrade

Failure in the unit test seems not to relate to this PR.

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[qliphy]

merge

[cvuosalo]

Why is this seemingly duplicate material introduced? It has the same density as materials:Borated Polyethyl..

[fabiocos]

@cvuosalo this is essentially a workaround to let the material budget validation code parsing without issues the tables with the material names, it is unclear to me how to handle blanks in the middle (it was a bad idea to introduce them in first place, I would say). I mimicked what done already for other similar situations, see for instance

https://cmssdt.cern.ch/lxr/source/Geometry/CMSCommonData/data/materials.xml#1157

If you have a better solution to suggest I will be happy to consider it, I do not like this solution either, but "it just works".

[cvuosalo]

@fabiocos Thanks, I understand now. It is unfortunate that we are stuck with this name containing a space, but I see it is widely used, so it would be some effort to change.