-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-Trk07 Take care of unit test failure in SimTracker/TrackerMaterialAnalysis #34596
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34596/24153
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
-1 Failed Tests: RelVals RelVals
|
@qliphy @silviodonato Please do the test once the issue of PPS xml files is resolved |
please test |
-1 Failed Tests: RelVals RelVals
|
@cmsbuild Please test |
@@ -52,7 +52,7 @@ | |||
from Configuration.AlCa.GlobalTag import GlobalTag | |||
process.GlobalTag = GlobalTag(process.GlobalTag, 'auto:phase2_realistic', '') | |||
else: | |||
process.load('Configuration.Geometry.GeometryExtended2026D49_cff') | |||
process.load('Configuration.Geometry.GeometryExtended2026D49Reco_cff') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this requires the reco geometry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason is HCAL went through a phase where HE was considered a possibility for Phase2 detector. That needs the grouping at SIM and RECO level to be different. Later Reco regrouping was needed in some SIM related studies. That is why it is always better to include the so called RECO geometry which any way has the SIM geometry inside it.
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Expand to see more relval errors ...
Comparison SummarySummary:
|
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-64c456/17141/summary.html Comparison SummarySummary:
|
@cvuosalo @qliphy @perrotta @silviodonato @civanch Kindly approve and integrate this PR on an urgent basis to remove the unit test failure message |
+geometry |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Take care of unit test failure in SimTracker/TrackerMaterialAnalysis
PR validation:
Ran the scripts in the test area
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special