Add esConsumes for code using TransientTrack::setES

[Dr15Jones]

PR description:

-removed the function TransientTrack::setES
-replaced all calls to TransientTrack::setES with TransientTrack::setTrackingGeometry which leave the object in the same state
-call esConsumes for code that had easy access to that function and used TransientTrack::setES

PR validation:

Code compiles.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34584/24135

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• Alignment/ReferenceTrajectories (alca)
• CommonTools/RecoUtils (analysis)
• RecoTracker/TrackProducer (reconstruction)
• TrackingTools/TransientTrack (reconstruction)

@perrotta, @malbouis, @yuanchao, @tlampen, @cmsbuild, @slava77, @jpata, @pohsun, @francescobrivio, @santocch, @tvami can you please review it and eventually sign? Thanks.
@felicepantaleo, @abbiendi, @tlampen, @mmusich, @cericeci, @makortel, @JanFSchulte, @jhgoh, @sscruz, @trocino, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @tocheng, @ebrondol, @mtosi, @dgulhan, @HuguesBrun, @adewit, @Fedespring, @calderona, @lecriste, @gpetruc this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[mmusich]

Isn't this syntax deprecated?

[Dr15Jones]

Yes. However I decided I did not want to try modifying this code and all code that uses it to support esConsumes. The goal of this PR was really just to update PFCand_AssoMap since it is used in the IBs. The change above will make it easier in the future to migrate this code to esConsumes.

[Dr15Jones]

Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34584/24145

• This PR adds an extra 48KB to repository

[cmsbuild]

Pull request #34584 was updated. @perrotta, @malbouis, @yuanchao, @tlampen, @cmsbuild, @slava77, @jpata, @pohsun, @francescobrivio, @santocch, @tvami can you please check and sign again.

[Dr15Jones]

please test

[Dr15Jones]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e89c0/17157/summary.html
COMMIT: 586f21e
CMSSW: CMSSW_12_0_X_2021-07-23-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34584/17157/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 4 EventSetupRecord::get warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e89c0/17157/llvm-analysis/esrget-sa.txt for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 18
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2998523
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[yuanchao]

+1

• migrated MagneticField and GlobalTrackingGeometry access in PFCand_AssoMap to esConsumes
• code refactored for future migration (deprecated codes still in other parts than PFCand_AssoMap)
• matrix tests and unit tests passed.

[jpata]

+reconstruction

• technical, no reco changes expected/observed

[qliphy]

+1

[qliphy]

merge

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.