Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python3 to generate geometry #34554

Closed
wants to merge 1 commit into from
Closed

Use python3 to generate geometry #34554

wants to merge 1 commit into from

Conversation

iarspider
Copy link
Contributor

PR description:

Possible fix for #34552. Similar to #34474.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34554/24083

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • Configuration/Geometry (geometry, upgrade)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @kpedro88, @cmsbuild, @srimanob, @mdhildreth can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @slomeo, @vargasa this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor

Please test

@cvuosalo
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build HeaderConsistency ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b20f2e/16997/summary.html
COMMIT: 86d424e
CMSSW: CMSSW_12_0_X_2021-07-19-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34554/16997/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b20f2e/16997/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b20f2e/16997/git-merge-result

Build

I found compilation error when building:

>> Leaving Package HeterogeneousCore/SonicTriton
>> Package HeterogeneousCore/SonicTriton built
Entering library rule at src/HeterogeneousCore/SonicTriton/plugins
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-19-1100/src/HeterogeneousCore/SonicTriton/plugins/TritonService.cc
In file included from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-19-1100/src/HeterogeneousCore/SonicTriton/plugins/TritonService.cc:3:
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-19-1100/src/HeterogeneousCore/SonicTriton/interface/TritonService.h:13:10: fatal error: grpc_client.h: No such file or directory
   13 | #include "grpc_client.h"
      |          ^~~~~~~~~~~~~~~
compilation terminated.
In file included from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-19-1100/src/HeterogeneousCore/SonicTriton/plugins/TritonService.cc:3:
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-19-1100/src/HeterogeneousCore/SonicTriton/interface/TritonService.h:13:10: fatal error: grpc_client.h: No such file or directory


Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 64 COMPILER='llvm compile'

>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-19-1100/src/HeterogeneousCore/SonicCore/test/SonicDummyOneAnalyzer.cc
>> Entering Package HeterogeneousCore/SonicTriton
Entering library rule at src/HeterogeneousCore/SonicTriton/plugins
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-19-1100/src/HeterogeneousCore/SonicTriton/plugins/TritonService.cc
In file included from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-19-1100/src/HeterogeneousCore/SonicTriton/plugins/TritonService.cc:3:
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-19-1100/src/HeterogeneousCore/SonicTriton/interface/TritonService.h:13:10: fatal error: 'grpc_client.h' file not found
#include "grpc_client.h"
         ^~~~~~~~~~~~~~~
1 error generated.
In file included from /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-19-1100/src/HeterogeneousCore/SonicTriton/plugins/TritonService.cc:3:
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-07-19-1100/src/HeterogeneousCore/SonicTriton/interface/TritonService.h:13:10: fatal error: 'grpc_client.h' file not found


@iarspider
Copy link
Contributor Author

test parameters:
pull_request = cms-sw/cmsdist#7142

@iarspider
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b20f2e/17008/summary.html
COMMIT: 86d424e
CMSSW: CMSSW_12_0_X_2021-07-19-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34554/17008/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b20f2e/17008/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b20f2e/17008/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test EcalDAQ_O2O_test had ERRORS
---> test EcalDCS_O2O_test had ERRORS
---> test EcalLaser_O2O_test had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2996268
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2996245
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@iarspider
Copy link
Contributor Author

iarspider commented Jul 21, 2021

Closing in favor of #34534

@iarspider iarspider closed this Jul 21, 2021
@iarspider iarspider deleted the patch-3 branch July 21, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants