-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-gex83C Convert one more SD (Hcal) to new format #34521
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34521/24033
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34521/24035
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Please test |
-1 Failed Tests: HeaderConsistency Comparison SummarySummary:
|
@smuzaffar @qliphy @silviodonato @perrotta The unit failure is not linked with this PR. It is in the current IB against which it is tested. Could care be taken for that? |
@cmsbuild Please test |
-1 Failed Tests: HeaderConsistency UnitTests Unit TestsI found errors in the following unit tests: ---> test TestDQMServicesDemo had ERRORS Comparison SummarySummary:
|
please test |
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test TestDQMServicesDemo had ERRORS Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
@cmsbuild Please test |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ad88c/17036/summary.html Comparison SummarySummary:
|
@@ -12,8 +11,6 @@ | |||
|
|||
typedef ECalSD EcalSensitiveDetector; | |||
DEFINE_SENSITIVEDETECTOR(EcalSensitiveDetector); | |||
typedef HCalSD HcalSensitiveDetector; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bsunanda , where HCalSD is now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HcalSensitiveDetectorBuilder instantiates HCalSD as HcalSensitiveDetector by supplying all objects needed from EventSetup
@civanch Please approve this. After it is integrated I can do this for other detectors in Calo |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Convert one more SD (Hcal) to new format and move the one for CaloTrkProcessing to plugins
PR validation:
Use the runTheMatrix test workflows
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special