-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Used importlib in scripts #34490
Used importlib in scripts #34490
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34490/23962
|
A new Pull Request was created by @sroychow (Suvankar Roy Chowdhury) for master. It involves the following packages:
@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@davidlange6 Can you comment if this looks reasonable? |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34490/23970
|
Pull request #34490 was updated. @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please check and sign again. |
I think the new syntax is correct ... but apparently also one that is going to be deprecated.. See the suggestion here: |
Milestone for this pull request has been moved to CMSSW_14_0_X.Please open a backport if it should also go in to CMSSW_13_3_X. |
Milestone for this pull request has been moved to CMSSW_14_1_X. Please open a backport if it should also go in to CMSSW_14_0_X. |
ping |
Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X. |
Given that this PR is a draft and has been unattended for 3 years, I think we can close it |
-core |
@cmsbuild, please close |
PR description:
Proposed fix to #34489.
PR validation:
Checked locally that the dump output remains the same after the changes.
if this PR is a backport please specify the original PR and why you need to backport that PR:
NA