Use RooMinimizer instead of RooMinuit after ROOT deprecation for RooMunuit

[mrodozov]

PR description:

ROOT has changed the RooMinuit usage in here:
root-project/root#8369
here:
root-project/root#8596
and here:
root-project/root#8567
suggesting to use RooMinimizer
https://github.com/root-project/root/blob/master/roofit/roofitcore/inc/RooMinuit.h

PR validation:

PhysicsTools/TagAndProbe is building

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34461/23909

ERROR: Build errors found during clang-tidy run.

PhysicsTools/TagAndProbe/src/TagProbeFitter.cc:36:10: error: 'RooFitLegacy/RooMinuit.h' file not found [clang-diagnostic-error]
#include "RooFitLegacy/RooMinuit.h"
         ^
Suppressed 2971 warnings (2970 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34461/23912

• This PR adds an extra 40KB to repository

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

• MuonAnalysis/MomentumScaleCalibration (analysis)
• PhysicsTools/TagAndProbe (analysis)

@cmsbuild, @santocch can you please review it and eventually sign? Thanks.
@rchatter, @argiro, @bellan, @thomreis, @simonepigazzini, @mmusich this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e5e65b/16759/summary.html
COMMIT: 374b4ff
CMSSW: CMSSW_12_0_X_2021-07-12-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34461/16759/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2786302
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2786273
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e5e65b/16844/summary.html
COMMIT: 374b4ff
CMSSW: CMSSW_12_0_X_2021-07-14-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34461/16844/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2786302
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2786279
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[smuzaffar]

@qliphy , @silviodonato @perrotta can we merge this? this is needed for root master IBs where build fails

CMSSW_12_0_ROOT6_X_2021-07-15-2300/src/PhysicsTools/TagAndProbe/src/TagProbeFitter.cc:36:10: fatal error: RooMinuit.h: No such file or directory
   36 | #include "RooMinuit.h"

[qliphy]

+1

[qliphy]

merge

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.