Bugfix: pick right jet collection for Type1 PUPPI MET when reapplying JECs

[lathomas]

PR description:

A difference between 10_6_X and master was observed by @gouskos @mariadalfonso for the Type1 PUPPI MET in NANOAOD.
After some investigation it looks like the wrong jet collection (CHS jets, instead of PUPPI jets) is used in master while the proper one is used in 106X.
https://github.com/cms-sw/cmssw/blob/CMSSW_10_6_X/PhysicsTools/PatUtils/python/tools/runMETCorrectionsAndUncertainties.py#L1564
This PR corrects this

PR validation:

It was checked that PUPPI MET agrees between 106X and master in NANOAOD after the fix.
runTheMatrix was successfully run on two workflows (reMINIAOD and reNANOAOD)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34449/23884

• This PR adds an extra 32KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/PatUtils/python/tools/runMETCorrectionsAndUncertainties.py modified in PR(s): Unify vertex association between CHS and PUPPI #33885

[cmsbuild]

A new Pull Request was created by @lathomas for master.

It involves the following packages:

• PhysicsTools/PatUtils (reconstruction)

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @gouskos, @JyothsnaKomaragiri, @ahinzmann, @schoef, @rappoccio, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @emilbols, @hatakeyamak, @gpetruc, @andrzejnovak, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0c7ab0/16729/summary.html
COMMIT: 40d168d
CMSSW: CMSSW_12_0_X_2021-07-12-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34449/16729/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 32 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2787742
• DQMHistoTests: Total failures: 856
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2786886
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[perrotta]

@ahinzmann the fix proposed here reverts a change that you introduced in the master with #28936: do you remember the purpose of that change, and do you see any counter-indication in reverting it here?

[jpata]

kind ping @ahinzmann (just in case)

[jpata]

+reconstruction

• despite some confusion with respect to this change overriding an older one in 9511a7f (PR PUPPI jets in RECO #28936), signing this now as it comes from JetMET
• reco differences observed and expected in NANO puppiMET

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[ahinzmann]

@ahinzmann the fix proposed here reverts a change that you introduced in the master with #28936: do you remember the purpose of that change, and do you see any counter-indication in reverting it here?

For the record: So I had a look at #28936 and don't remember why this change was made. It looks like a bug to me now, so what is done here makes sense.