Reorganise RecoMuon/L2MuonProducer plugins

[fwyzard]

PR description:

Move plugins from the src to the plugins directory, and merge the header and source files.

PR validation:

None.

[fwyzard]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34399/23797

• This PR adds an extra 16KB to repository

• Found files with invalid states:

  • RecoMuon/L2MuonProducer/plugins/L2MuonProducer.h:
    • Added: 91e189f
    • Deleted: 714a55c
  • RecoMuon/L2MuonProducer/plugins/SealModule.cc:
    • Added: 91e189f
    • Deleted: 714a55c
  • RecoMuon/L2MuonProducer/plugins/L2MuonCandidateProducer.h:
    • Added: 91e189f
    • Deleted: 714a55c

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

RecoMuon/L2MuonProducer (hlt, reconstruction)

@Martin-Grunewald, @perrotta, @fwyzard, @jpata, @slava77 can you please review it and eventually sign? Thanks.
@HuguesBrun, @bellan, @abbiendi, @Fedespring, @calderona, @sscruz, @jhgoh, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6338a6/16602/summary.html
COMMIT: 714a55c
CMSSW: CMSSW_12_0_X_2021-07-07-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34399/16602/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 5119 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2786260
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2786231
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[perrotta]

please test
(It is hard to imagine how all those quite significant differences in the miniAOD slimmed jets can come from this PR: let try to relaunch the tests once more. just in case...)

[davidlange6]

These differences were understood on Thursday to be due to non-deterministic sorting in python. Its fixed now if I understand.

…

On Jul 12, 2021, at 10:23 AM, Andrea Perrotta ***@***.***> wrote: please test (It is hard to imagine how all those quite significant differences in the miniAOD slimmed jets can come from this PR: let try to relaunch the tests once more. just in case...) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[perrotta]

These differences were understood on Thursday to be due to non-deterministic sorting in python. Its fixed now if I understand.

Thank you @davidlange6
Let have a look at the new test results then, once available

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6338a6/16697/summary.html
COMMIT: 714a55c
CMSSW: CMSSW_12_0_X_2021-07-11-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34399/16697/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2787742
• DQMHistoTests: Total failures: 892
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2786849
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 37 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[slava77]

DQMHistoTests: Total failures: 892

these are apparently from TimingService. I thought that these diffs were skipped/ignored before.
@smuzaffar do you know?

[slava77]

+reconstruction

for #34399 714a55c

• code changes are technical, in line with the PR description
• jenkins tests pass and comparisons with the baseline show no relevant differences

[smuzaffar]

@slava77 , yes looks like moving Relmon to python3 is not skipping the timing services related stuff. @davidlange6 is looking in to it.

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1