Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mkFit to support additional tracking iterations and other technical developments #34395

Merged
merged 9 commits into from
Jul 20, 2021

Conversation

mmasciov
Copy link
Contributor

@mmasciov mmasciov commented Jul 8, 2021

PR description:

This PR follows #33802 and #34198, and updates mkFit to support multiple tracking iterations. An option is added to switch pattern recognition to MkFit for pixelPairStep. Modifiers for each of iteration are added to allow switching any set of them to be switched to MkFit.

In addition this PR includes:

  • option to use SiStrip quality DB information;
  • switch of mkFit state conversion to use curvilinear covariance;
  • other technical optimizations.

It requires cms-sw/cmsdist#7113 and cms-data/RecoTracker-MkFit#2

All developments have been already presented at Tracking POG (https://indico.cern.ch/event/1045001/#2-mkfit-status-report).

FYI @mtosi @vmariani @mmusich
(@slava77 @makortel)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2021

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34395/23790

ERROR: Build errors found during clang-tidy run.

RecoTracker/MkFit/plugins/MkFitEventOfHitsProducer.cc:83:24: error: no member named 'DeadVec' in namespace 'mkfit' [clang-diagnostic-error]
    std::vector<mkfit::DeadVec> deadvectors(mkFitGeom.layerNumberConverter().nLayers());
                       ^
RecoTracker/MkFit/plugins/MkFitEventOfHitsProducer.cc:100:20: error: no member named 'LoadDeads' in namespace 'mkfit::StdSeq' [clang-diagnostic-error]
    mkfit::StdSeq::LoadDeads(*eventOfHits, deadvectors);
                   ^
Suppressed 1354 warnings (1353 in non-user code, 1 with check filters).
--
RecoTracker/MkFit/plugins/MkFitSeedConverter.cc:123:11: error: no member named 'convertFromGlbCurvilinearToCCS' in 'mkfit::TrackState'; did you mean 'convertFromCartesianToCCS'? [clang-diagnostic-error]
    state.convertFromGlbCurvilinearToCCS();
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          convertFromCartesianToCCS
--
RecoTracker/MkFit/plugins/MkFitOutputConverter.cc:278:11: error: no member named 'convertFromCCSToGlbCurvilinear' in 'mkfit::TrackState'; did you mean 'convertFromCCSToCartesian'? [clang-diagnostic-error]
    state.convertFromCCSToGlbCurvilinear();
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          convertFromCCSToCartesian
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

@smuzaffar
Copy link
Contributor

code-checks with cms.week0.PR_39263eff/46.0-348374335f5d5b2a762b0851f5953137

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34395/23791

  • This PR adds an extra 40KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2021

A new Pull Request was created by @mmasciov (Mario Masciovecchio) for master.

It involves the following packages:

Configuration/ProcessModifiers (operations)
RecoTracker/IterativeTracking (reconstruction)
RecoTracker/MkFit (reconstruction)

@perrotta, @silviodonato, @cmsbuild, @slava77, @jpata, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @ebrondol, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Jul 8, 2021

test parameters:

@slava77
Copy link
Contributor

slava77 commented Jul 8, 2021

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34395/24051

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #34395 was updated. @perrotta, @silviodonato, @cmsbuild, @slava77, @jpata, @qliphy, @fabiocos, @davidlange6 can you please check and sign again.

@jpata
Copy link
Contributor

jpata commented Jul 19, 2021

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-91482a/16983/summary.html
COMMIT: 3be4df2
CMSSW: CMSSW_12_0_X_2021-07-18-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34395/16983/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-91482a/16983/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-91482a/16983/git-merge-result

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-91482a/11634.912_TTbar_14TeV+2021_DD4hepDB+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2996268
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2996239
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@jpata
Copy link
Contributor

jpata commented Jul 20, 2021

+reconstruction

@qliphy
Copy link
Contributor

qliphy commented Jul 20, 2021

+operations

@qliphy
Copy link
Contributor

qliphy commented Jul 20, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 1662928 into cms-sw:master Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants