-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mkFit to support additional tracking iterations and other technical developments #34395
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34395/23790 ERROR: Build errors found during clang-tidy run.
|
code-checks with cms.week0.PR_39263eff/46.0-348374335f5d5b2a762b0851f5953137 |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34395/23791
|
A new Pull Request was created by @mmasciov (Mario Masciovecchio) for master. It involves the following packages: Configuration/ProcessModifiers (operations) @perrotta, @silviodonato, @cmsbuild, @slava77, @jpata, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
@cmsbuild please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34395/24051
|
Pull request #34395 was updated. @perrotta, @silviodonato, @cmsbuild, @slava77, @jpata, @qliphy, @fabiocos, @davidlange6 can you please check and sign again. |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-91482a/16983/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+reconstruction
|
+operations |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
This PR follows #33802 and #34198, and updates mkFit to support multiple tracking iterations. An option is added to switch pattern recognition to MkFit for pixelPairStep. Modifiers for each of iteration are added to allow switching any set of them to be switched to MkFit.
In addition this PR includes:
It requires cms-sw/cmsdist#7113 and cms-data/RecoTracker-MkFit#2
All developments have been already presented at Tracking POG (https://indico.cern.ch/event/1045001/#2-mkfit-status-report).
FYI @mtosi @vmariani @mmusich
(@slava77 @makortel)