Introduce conddb script unit tests

[mmusich]

PR description:

This is inspired from #34378.
In commit 0daa900 a unit test to check basic functionalities of the conddb script is added.
In commit 2927fc9 a protection for conddb diffGlobalTagsAtRun is added, in order not go in error if it's run=1 (that's MC)

PR validation:

The newly introduced unit test passes:

scram b runtests_test_conddb

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34392/23787

• This PR adds an extra 44KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CondCore/Utilities/test/BuildFile.xml modified in PR(s): introduce uploadConditions.py unit test #34379

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondCore/Utilities (db)

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-892eb1/16590/summary.html
COMMIT: 10ec355
CMSSW: CMSSW_12_0_X_2021-07-07-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34392/16590/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 5120 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2786260
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2786225
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34392/23830

• This PR adds an extra 40KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CondCore/Utilities/scripts/conddb modified in PR(s): Moving conddb tools to python3  #34402
  • File CondCore/Utilities/test/BuildFile.xml modified in PR(s): introduce uploadConditions.py unit test #34379

[cmsbuild]

Pull request #34392 was updated. @ggovi, @cmsbuild can you please check and sign again.

[qliphy]

please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-892eb1/17014/summary.html
COMMIT: 4cc9355
CMSSW: CMSSW_12_0_X_2021-07-19-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34392/17014/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @makortel Protect all TTree::Fill() calls with tbb::this_task_arena::isolate() in DQMRootOutputModule #34532
• @civanch Improved OscarMTProducer debug printout #34497
• @bsunanda Run3-gex83F Update SD class initializations in SimG4CMS/HGCalTestBeam #34539
• @kpedro88 SonicTriton feature updates, improvements, bug fixes #34508
• @slava77 update mkfit to V3.1.0 cmsdist#7113
• @cms-sw [Tensorflow] Update to version 2.5.0 cmsdist#7141
• @kpedro88 Update Triton to v2.11 cmsdist#7142
• @cms-sw Update tag for RecoTracker-MkFit to V00-02-00 cmsdist#7149

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-892eb1/17014/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-892eb1/17014/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test EcalDAQ_O2O_test had ERRORS
---> test EcalDCS_O2O_test had ERRORS
---> test EcalLaser_O2O_test had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2996268
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2996245
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[mmusich]

test parameters:

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-892eb1/17045/summary.html
COMMIT: 4cc9355
CMSSW: CMSSW_12_0_X_2021-07-20-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34392/17045/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2996268
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2996239
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[mmusich]

Can we please merge this before the release gets broken in 10,000 other ways? Thanks

[davidlange6]

Having just waited 2 weeks for a simple db PR (whose absence broke the second round of your PR tests), I guess this PR is still too young to be signed:)

…

On Jul 21, 2021, at 12:42 PM, Marco Musich ***@***.***> wrote: Can we please merge this before the release gets broken in 10,000 other ways? Thanks — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1