Added scintillator information to RecHitTools

[jkiesele]

PR description:

This PR implements a new feature for the RecHitTools to conveniently access the size of individual HGCAL scintillator cells through their detID. While in the current geometry the size is constant for all cells, this implementation avoids hard-coding the size and is transparent w.r.t. geometry changes.
This feature is useful to study shower densities on truth level, and possibly for studying clustering algorithms.

The addition was discussed in the HGCAL DPG meeting: https://indico.cern.ch/event/1055901/

PR validation:

The code has been validated to produce the right sizes in eta and phi. It is also stable against wrong detID inputs.
Since it implements a new feature, there are no downstream dependencies.

[jkiesele]

@rovere , @pfs , @cseez

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34391/23786

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @jkiesele (Jan Kieseler) for master.

It involves the following packages:

RecoLocalCalo/HGCalRecAlgos (upgrade, reconstruction)

@perrotta, @kpedro88, @cmsbuild, @srimanob, @slava77, @jpata can you please review it and eventually sign? Thanks.
@edjtscott, @vandreev11, @lecriste, @sethzenz, @bsunanda, @rchatter, @felicepantaleo, @rovere, @lgray, @cseez, @apsallid, @pfs, @thomreis, @hatakeyamak, @simonepigazzini, @ebrondol, @argiro, @clelange this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31c801/16591/summary.html
COMMIT: 17ac0c3
CMSSW: CMSSW_12_0_X_2021-07-07-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34391/16591/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 5155 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2786260
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2786237
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[slava77]

Reco comparison results: 5155 differences found in the comparisons

this seems related to the discussion in cms-sw/cmsdist#7112 (comment)

@makortel @davidlange6
does it confirm now that the python list order is no longer repeatable ?

[makortel]

does it confirm now that the python list order is no longer repeatable ?

It certainly confirms that something unexpected is going on. I'll try to investigate as well.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34391/23807

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #34391 was updated. @perrotta, @kpedro88, @cmsbuild, @srimanob, @slava77, @jpata can you please check and sign again.

[felicepantaleo]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31c801/16613/summary.html
COMMIT: 3046eb5
CMSSW: CMSSW_12_0_X_2021-07-08-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34391/16613/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 5141 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2786260
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2786237
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #34391 3046eb5

• code changes are in line with the PR description and the follow up review
  • the code changes look generally OK (without an explicit use case)
• jenkins tests pass and comparisons with the baseline show no (relevant) differences, since the new code is not used yet
  • differences in reco comparisons are related to the status of the PAT/miniAOD jet tagging code in the IB and will be fixed after sort or order btags in python configuration #34409 is merged in a reference IB

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1