-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DQM] Move to python3 all scripts in DQMServices #34374
Conversation
urgent |
+1 |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34374/23757
|
A new Pull Request was created by @jfernan2 for master. It involves the following packages: DQMServices/Components can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34374/23759
|
Pull request #34374 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again. |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34374/23760
|
Pull request #34374 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @jfernan2, @rvenditti can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-27b877/16538/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@jfernan2 , looks like DQM bin by bin comparison still failing
can you please test |
As pointed out in cms-sw#34374 (comment)
Thanks @smuzaffar |
As pointed out in cms-sw#34374 (comment)
@@ -1,4 +1,4 @@ | |||
#!/usr/bin/env python | |||
#!/usr/bin/env python3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this ever tested after migration, see https://cms-talk.web.cern.ch/t/dqm-access-script-is-broken-in-recent-cmssw-releases/22637 ?
PR description:
Since CMSSW_12_0_X_2021-07-06-0300 DQM Bin By Bin tool is crashing in Jenkins tests. It looks like Jenkins test is already using python3.
This PR is urgently needed to put back the Bin By Bin tool