-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CosmicRateAnalyzer Updates: added PIXEL Hit Rate + improved Plots layout #34345
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34345/23719
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
@saumyaphor4252 thanks for this. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34345/23721
|
A new Pull Request was created by @saumyaphor4252 (Saumya) for master. It involves the following packages: Alignment/TrackerAlignment @malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test test_PixelBaryCentreTool had ERRORS Comparison SummarySummary:
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3a447f/16517/summary.html Comparison SummarySummary:
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3a447f/16743/summary.html Comparison SummarySummary:
|
+alca |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR Description
Updated the Cosmic Rate Analyzer:
a) plugins/CosmicRateAnalyzer.cc
b) macros/CosmicRateTool_PIXEL_HitRates.C
a) macros/CosmicRateTool_Kinematics.C
b) macros/CosmicRateTool_CosmicRates.C
a) scripts/runPlotter.sh
b) scripts/runListId.sh