-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EMTF Emulator Update to Add Run 3 CSC TP variables #34334
Conversation
… it on/off in config
…new variables to EMTFTrack collection. Added era options to simEmtfDigis
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34334/23696
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34334/23700
|
A new Pull Request was created by @eyigitba for master. It involves the following packages: DataFormats/L1TMuon @cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a406a5/16483/summary.html Comparison SummarySummary:
|
+l1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR adds support for Run 3 CSC TP variables in EMTF, mostly based on examples by @dildick . The CCLUT algorithm is currently not turned on in CSC TP emulator, so this will stay disabled on EMTF side as well. Therefore we expect no changes after this PR for now. The functionality will be turned on once everything is ready on CSC and EMTF side.
EMTFHit
,EMTFTrack
, andMuonTriggerPrimitive
data formats to add the new parameters.PrimitiveConversion
to use new variables when they are enabledsimEmtfDigis
to enable/disable the functionality. For now keeping the flag asFalse
will be turned on depending era in the future.PR validation:
Validated with:
Notifications: @jiafulow @dildick