modified the various (ES)producers for express stream and HLT #34295

gennai · 2021-07-01T09:05:28Z

I have modified the Online BS Producers to take the values from the transient record produced in the related ESProducer.
This is intended for HLT and express stream reconstruction for Run3. There is a new parameter that if set to False, it would revert back to Run2 code.

A second PR on a ERA modifier configuration will follow.

PR validation:

I have checked the behavior of the code using the test_scalers.py script modified accordingly

…beamspot use for Run3

gennai · 2021-07-01T09:05:59Z

@mtosi @mmusich @francescobrivio you may want to check this one

cmsbuild · 2021-07-01T09:14:44Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34295/23614

This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34295/23614/code-checks.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34295/23614/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34295/23614/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34295/23614/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

mmusich · 2021-07-01T09:21:10Z

RecoVertex/BeamSpotProducer/plugins/BeamSpotOnlineProducer.cc

+        fallBackToDB = true;
+      }else{
+        // translate from BeamSpotObjects to reco::BeamSpot
+        reco::BeamSpot::Point apoint(spotDB.GetX(), spotDB.GetY(), spotDB.GetZ());


shouldn't also this mode support the frame conversion?
See:

cmssw/RecoVertex/BeamSpotProducer/plugins/BeamSpotOnlineProducer.cc

Lines 91 to 93 in 9519f09

double f = 1.;

if (changeFrame_)

f = -1.;

I was unsure about this, if you think it is the proper thing to do I can do that. I did not know what this changeFrame was used for

well, if you don't do it, it won't reproduce the previous behaviour, so I think it should be added.

mmusich · 2021-07-01T09:24:57Z

RecoVertex/BeamSpotProducer/test/test_scalars.py


+                                ),
+                                        connect = cms.string('oracle://cms_orcon_prod/CMS_CONDITIONS')


this in general won't work unless you have the appropriate credentials.
For a test can't you use frontier instead?

checking now

mmusich · 2021-07-01T10:49:08Z

code-checks

cmsbuild · 2021-07-01T10:56:50Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34295/23619

This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34295/23619/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34295/23619/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-07-01T11:33:30Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34295/23620

This PR adds an extra 20KB to repository

cmsbuild · 2021-07-01T11:33:56Z

A new Pull Request was created by @gennai (simone gennai) for master.

It involves the following packages:

RecoVertex/BeamSpotProducer

@perrotta, @malbouis, @yuanchao, @tlampen, @cmsbuild, @slava77, @jpata, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @tocheng, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

mmusich · 2021-07-01T11:35:09Z

@cmsbuild, please test

Co-authored-by: Joosep Pata <[email protected]>

cmsbuild · 2021-07-02T13:35:36Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34295/23655

This PR adds an extra 16KB to repository

cmsbuild · 2021-07-02T13:36:01Z

Pull request #34295 was updated. @perrotta, @malbouis, @yuanchao, @tlampen, @cmsbuild, @slava77, @jpata, @pohsun, @francescobrivio, @tvami can you please check and sign again.

qliphy · 2021-07-04T04:41:10Z

test parameters:

workflow = 138.2

qliphy · 2021-07-04T04:42:08Z

please test

cmsbuild · 2021-07-04T11:38:54Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-097fed/16444/summary.html
COMMIT: b1d5e95
CMSSW: CMSSW_12_0_X_2021-07-03-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34295/16444/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-097fed/138.2_RunCosmics2020+RunCosmics2020+RECOCOSDEXPRUN3+ALCACOSDEXPRUN3+HARVESTDCEXPRUN3

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2785924
DQMHistoTests: Total failures: 12
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2785889
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: no differences found

francescobrivio · 2021-07-05T08:22:43Z

+alca

jpata · 2021-07-05T10:58:38Z

+reconstruction

adds a new useTransientRecord option to BeamSpotOnlineProducer for HLT and Run3 express stream, off by default
no reco changes, except in the cosmics workflow 138.2, the beamspot type is now 2 (it was -1 previously)

cmsbuild · 2021-07-05T10:59:02Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-07-05T14:30:47Z

+1

modified the various (ES)producers for proper express stream and HLT …

df4ecf2

…beamspot use for Run3

cmsbuild added this to the CMSSW_12_0_X milestone Jul 1, 2021

cmsbuild added alca-pending code-checks-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jul 1, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jul 1, 2021

mmusich reviewed Jul 1, 2021

View reviewed changes

gennai added 2 commits July 1, 2021 12:31

applied code checks and format patches

cd60678

Applied suggestion from Marco Musich

759f610

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jul 1, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jul 1, 2021

applied Era mechanism to activate the changes in the producer

6c173d2

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jul 1, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 1, 2021

Update RecoVertex/BeamSpotProducer/plugins/BeamSpotOnlineProducer.cc

b1d5e95

Co-authored-by: Joosep Pata <[email protected]>

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved requires-external tests-approved labels Jul 2, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 2, 2021

cmsbuild added tests-started and removed tests-pending labels Jul 4, 2021

cmsbuild added tests-approved and removed tests-started labels Jul 4, 2021

cmsbuild added alca-approved and removed alca-pending labels Jul 5, 2021

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Jul 5, 2021

cmsbuild added orp-approved and removed orp-pending labels Jul 5, 2021

cmsbuild merged commit dbeaf36 into cms-sw:master Jul 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

modified the various (ES)producers for express stream and HLT #34295

modified the various (ES)producers for express stream and HLT #34295

gennai commented Jul 1, 2021

gennai commented Jul 1, 2021

cmsbuild commented Jul 1, 2021

mmusich Jul 1, 2021

gennai Jul 1, 2021

mmusich Jul 1, 2021

gennai Jul 1, 2021

mmusich Jul 1, 2021

gennai Jul 1, 2021

mmusich commented Jul 1, 2021

cmsbuild commented Jul 1, 2021

cmsbuild commented Jul 1, 2021

cmsbuild commented Jul 1, 2021

mmusich commented Jul 1, 2021

cmsbuild commented Jul 2, 2021

cmsbuild commented Jul 2, 2021

qliphy commented Jul 4, 2021 •

edited

Loading

qliphy commented Jul 4, 2021

cmsbuild commented Jul 4, 2021

francescobrivio commented Jul 5, 2021

jpata commented Jul 5, 2021

cmsbuild commented Jul 5, 2021

qliphy commented Jul 5, 2021


		),
		connect = cms.string('oracle://cms_orcon_prod/CMS_CONDITIONS')

modified the various (ES)producers for express stream and HLT #34295

modified the various (ES)producers for express stream and HLT #34295

Conversation

gennai commented Jul 1, 2021

PR validation:

gennai commented Jul 1, 2021

cmsbuild commented Jul 1, 2021

mmusich Jul 1, 2021

Choose a reason for hiding this comment

gennai Jul 1, 2021

Choose a reason for hiding this comment

mmusich Jul 1, 2021

Choose a reason for hiding this comment

gennai Jul 1, 2021

Choose a reason for hiding this comment

mmusich Jul 1, 2021

Choose a reason for hiding this comment

gennai Jul 1, 2021

Choose a reason for hiding this comment

mmusich commented Jul 1, 2021

cmsbuild commented Jul 1, 2021

cmsbuild commented Jul 1, 2021

cmsbuild commented Jul 1, 2021

mmusich commented Jul 1, 2021

cmsbuild commented Jul 2, 2021

cmsbuild commented Jul 2, 2021

qliphy commented Jul 4, 2021 • edited Loading

qliphy commented Jul 4, 2021

cmsbuild commented Jul 4, 2021

Comparison Summary

francescobrivio commented Jul 5, 2021

jpata commented Jul 5, 2021

cmsbuild commented Jul 5, 2021

qliphy commented Jul 5, 2021

qliphy commented Jul 4, 2021 •

edited

Loading